ALSA: fireface: make read-only const array for model names static
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 27 Jun 2023 23:54:06 +0000 (08:54 +0900)
committerTakashi Iwai <tiwai@suse.de>
Wed, 28 Jun 2023 09:42:55 +0000 (11:42 +0200)
It is preferable not to populate the constant array for constant strings
on the stack.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20230627235406.289970-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/fireface/ff.c

index 8224105..6e84e47 100644 (file)
@@ -16,7 +16,7 @@ MODULE_LICENSE("GPL");
 static void name_card(struct snd_ff *ff)
 {
        struct fw_device *fw_dev = fw_parent_device(ff->unit);
-       const char *const names[] = {
+       static const char *const names[] = {
                [SND_FF_UNIT_VERSION_FF800]     = "Fireface800",
                [SND_FF_UNIT_VERSION_FF400]     = "Fireface400",
                [SND_FF_UNIT_VERSION_UFX]       = "FirefaceUFX",