aoe: remove redundant assignment on variable n
authorColin Ian King <colin.i.king@gmail.com>
Thu, 13 Jan 2022 00:05:45 +0000 (00:05 +0000)
committerJens Axboe <axboe@kernel.dk>
Thu, 13 Jan 2022 20:00:45 +0000 (13:00 -0700)
The variable n is being bit-wise or'd with a value and reassigned
before being returned. The update of n is redundant, replace
the |= operator with | instead. Cleans up clang scan warning:

drivers/block/aoe/aoecmd.c:125:9: warning: Although the value stored
to 'n' is used in the enclosing expression, the value is never
actually read from 'n' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220113000545.1307091-1-colin.i.king@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/aoe/aoecmd.c

index 588889b..6af111f 100644 (file)
@@ -122,7 +122,7 @@ newtag(struct aoedev *d)
        register ulong n;
 
        n = jiffies & 0xffff;
-       return n |= (++d->lasttag & 0x7fff) << 16;
+       return n | (++d->lasttag & 0x7fff) << 16;
 }
 
 static u32