f2fs: replace congestion_wait() calls with io_schedule_timeout()

As congestion is no longer tracked, congestion_wait() is effectively
equivalent to io_schedule_timeout().

So introduce f2fs_io_schedule_timeout() which sets TASK_UNINTERRUPTIBLE
and call that instead.

Link: https://lkml.kernel.org/r/164549983744.9187.6425865370954230902.stgit@noble.brown
Signed-off-by: NeilBrown <neilb@suse.de>
Cc: Anna Schumaker <Anna.Schumaker@Netapp.com>
Cc: Chao Yu <chao@kernel.org>
Cc: Darrick J. Wong <djwong@kernel.org>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Paolo Valente <paolo.valente@linaro.org>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index d0c3aeba594549f835bca3b96b70987de5b4d405..2f95559025ad3c7efe8edc7f8b7e246ceb8d0701 100644 (file)
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1505,9 +1505,7 @@ continue_unlock:
                                if (IS_NOQUOTA(cc->inode))
                                        return 0;
                                ret = 0;
-                               cond_resched();
-                               congestion_wait(BLK_RW_ASYNC,
-                                               DEFAULT_IO_TIMEOUT);
+                               f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
                                goto retry_write;
                        }
                        return ret;

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 8c417864c66ae3b5abdfbe0138cda383e71f9684..d428ddfd42ee12907c57aab41b2c8164be5317ef 100644 (file)
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3047,8 +3047,7 @@ result:
                                } else if (ret == -EAGAIN) {
                                        ret = 0;
                                        if (wbc->sync_mode == WB_SYNC_ALL) {
-                                               cond_resched();
-                                               congestion_wait(BLK_RW_ASYNC,
+                                               f2fs_io_schedule_timeout(
                                                        DEFAULT_IO_TIMEOUT);
                                                goto retry_write;
                                        }

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 68b44015514f51834b2c63b13bb37fb98d228bd3..467f5dbdc7d1f483c8c8a50b69823dc364810ca5 100644 (file)
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4426,6 +4426,12 @@ static inline bool f2fs_block_unit_discard(struct f2fs_sb_info *sbi)
        return F2FS_OPTION(sbi).discard_unit == DISCARD_UNIT_BLOCK;
 }
 
+static inline void f2fs_io_schedule_timeout(long timeout)
+{
+       set_current_state(TASK_UNINTERRUPTIBLE);
+       io_schedule_timeout(timeout);
+}
+
 #define EFSBADCRC      EBADMSG         /* Bad CRC detected */
 #define EFSCORRUPTED   EUCLEAN         /* Filesystem is corrupted */
 

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 1dabc8244083d84d1337f34597bdd918e7805b03..6ff20da44ad7770c7cadd3e085bd2553602f935f 100644 (file)
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -313,8 +313,7 @@ next:
 skip:
                iput(inode);
        }
-       congestion_wait(BLK_RW_ASYNC, DEFAULT_IO_TIMEOUT);
-       cond_resched();
+       f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
        if (gc_failure) {
                if (++looped >= count)
                        return;
@@ -803,8 +802,7 @@ int f2fs_flush_device_cache(struct f2fs_sb_info *sbi)
                do {
                        ret = __submit_flush_wait(sbi, FDEV(i).bdev);
                        if (ret)
-                               congestion_wait(BLK_RW_ASYNC,
-                                               DEFAULT_IO_TIMEOUT);
+                               f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
                } while (ret && --count);
 
                if (ret) {
@@ -3133,7 +3131,7 @@ next:
                        blk_finish_plug(&plug);
                        mutex_unlock(&dcc->cmd_lock);
                        trimmed += __wait_all_discard_cmd(sbi, NULL);
-                       congestion_wait(BLK_RW_ASYNC, DEFAULT_IO_TIMEOUT);
+                       f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
                        goto next;
                }
 skip:

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index baefd398ec1a384b017b04200edd8abe4d1e106f..ebd32daf052cfde6e4576e4d51b9b8d018ce6843 100644 (file)
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2135,8 +2135,7 @@ static void f2fs_enable_checkpoint(struct f2fs_sb_info *sbi)
        /* we should flush all the data to keep data consistency */
        do {
                sync_inodes_sb(sbi->sb);
-               cond_resched();
-               congestion_wait(BLK_RW_ASYNC, DEFAULT_IO_TIMEOUT);
+               f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
        } while (get_pages(sbi, F2FS_DIRTY_DATA) && retry--);
 
        if (unlikely(retry < 0))
@@ -2504,8 +2503,7 @@ retry:
                                                        &page, &fsdata);
                if (unlikely(err)) {
                        if (err == -ENOMEM) {
-                               congestion_wait(BLK_RW_ASYNC,
-                                               DEFAULT_IO_TIMEOUT);
+                               f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
                                goto retry;
                        }
                        set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR);