[IRInterpreter] Minor cleanups, add comments. NFCI.
authorDavide Italiano <davide@freebsd.org>
Fri, 14 Sep 2018 20:48:34 +0000 (20:48 +0000)
committerDavide Italiano <davide@freebsd.org>
Fri, 14 Sep 2018 20:48:34 +0000 (20:48 +0000)
llvm-svn: 342280

lldb/source/Expression/IRInterpreter.cpp

index 2c08d09..ac1c401 100644 (file)
@@ -601,17 +601,13 @@ bool IRInterpreter::CanInterpret(llvm::Module &module, llvm::Function &function,
         Value *operand = ii->getOperand(oi);
         Type *operand_type = operand->getType();
 
-        switch (operand_type->getTypeID()) {
-        default:
-          break;
-        case Type::VectorTyID: {
+        // Vectors are currently unsupported, give up.
+        if (operand_type->getTypeID() == Type::VectorTyID)
           if (log)
             log->Printf("Unsupported operand type: %s",
                         PrintType(operand_type).c_str());
           error.SetErrorString(unsupported_operand_error);
           return false;
-        }
-        }
 
         // The IR interpreter currently doesn't know about
         // 128-bit integers. As they're not that frequent,
@@ -625,7 +621,7 @@ bool IRInterpreter::CanInterpret(llvm::Module &module, llvm::Function &function,
           return false;
         }
 
-        if (Constant *constant = llvm::dyn_cast<Constant>(operand)) {
+        if (auto *constant = llvm::dyn_cast<Constant>(operand)) {
           if (!CanResolveConstant(constant)) {
             if (log)
               log->Printf("Unsupported constant: %s",