usb: typec: tcpci_maxim: remove redundant assignment
authorJunlin Yang <yangjunlin@yulong.com>
Sun, 24 Jan 2021 14:38:53 +0000 (22:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Jan 2021 10:36:59 +0000 (11:36 +0100)
PTR_ERR(chip->tcpci) has been used as a return value,
it is not necessary to assign it to ret, so remove it.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210124143853.1630-1-angkery@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpci_maxim.c

index 0e2bb12..63d8eff 100644 (file)
@@ -458,7 +458,6 @@ static int max_tcpci_probe(struct i2c_client *client, const struct i2c_device_id
        chip->tcpci = tcpci_register_port(chip->dev, &chip->data);
        if (IS_ERR(chip->tcpci)) {
                dev_err(&client->dev, "TCPCI port registration failed");
-               ret = PTR_ERR(chip->tcpci);
                return PTR_ERR(chip->tcpci);
        }
        chip->port = tcpci_get_tcpm_port(chip->tcpci);