test_objagg: Fix potential memory leak in error handling
authorAditya Pakki <pakki001@umn.edu>
Fri, 12 Jun 2020 20:01:54 +0000 (15:01 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Jun 2020 20:32:11 +0000 (13:32 -0700)
In case of failure of check_expect_hints_stats(), the resources
allocated by objagg_hints_get should be freed. The patch fixes
this issue.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/test_objagg.c

index 72c1abf..da13793 100644 (file)
@@ -979,10 +979,10 @@ err_check_expect_stats2:
 err_world2_obj_get:
        for (i--; i >= 0; i--)
                world_obj_put(&world2, objagg, hints_case->key_ids[i]);
-       objagg_hints_put(hints);
-       objagg_destroy(objagg2);
        i = hints_case->key_ids_count;
+       objagg_destroy(objagg2);
 err_check_expect_hints_stats:
+       objagg_hints_put(hints);
 err_hints_get:
 err_check_expect_stats:
 err_world_obj_get: