webrtcbin: also add rtcp-fb ccm fir for video mlines by default
authorMatthew Waters <matthew@centricular.com>
Thu, 20 Oct 2022 23:50:36 +0000 (10:50 +1100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Fri, 21 Oct 2022 01:02:34 +0000 (01:02 +0000)
In addition to the 'nack pli' already added.  Both are supported by
rtpbin/rtpsession by default already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3235>

subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c

index 7167b86..42c82f3 100644 (file)
@@ -1990,9 +1990,12 @@ _add_supported_attributes_to_caps (GstWebRTCBin * webrtc,
       if (!gst_structure_has_field (s, "rtcp-fb-nack"))
         gst_structure_set (s, "rtcp-fb-nack", G_TYPE_BOOLEAN, TRUE, NULL);
 
-    if (kind == GST_WEBRTC_KIND_VIDEO
-        && !gst_structure_has_field (s, "rtcp-fb-nack-pli"))
-      gst_structure_set (s, "rtcp-fb-nack-pli", G_TYPE_BOOLEAN, TRUE, NULL);
+    if (kind == GST_WEBRTC_KIND_VIDEO) {
+      if (!gst_structure_has_field (s, "rtcp-fb-nack-pli"))
+        gst_structure_set (s, "rtcp-fb-nack-pli", G_TYPE_BOOLEAN, TRUE, NULL);
+      if (!gst_structure_has_field (s, "rtcp-fb-ccm-fir"))
+        gst_structure_set (s, "rtcp-fb-ccm-fir", G_TYPE_BOOLEAN, TRUE, NULL);
+    }
     if (!gst_structure_has_field (s, "rtcp-fb-transport-cc"))
       gst_structure_set (s, "rtcp-fb-transport-cc", G_TYPE_BOOLEAN, TRUE, NULL);