sfc: Stop generating bogus events in tenxpress_check_hw()
authorBen Hutchings <bhutchings@solarflare.com>
Mon, 1 Sep 2008 11:50:01 +0000 (12:50 +0100)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 24 Sep 2008 22:54:39 +0000 (18:54 -0400)
mdio_clause45_links_ok() correctly checks efx_phy_mode_disabled(), so
tenxpress_link_ok() doesn't need to.

From: Steve Hodgson <shodgson@solarflare.com>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/sfc/tenxpress.c

index 2ad3d8d..d507c93 100644 (file)
@@ -377,8 +377,7 @@ static int tenxpress_phy_check_hw(struct efx_nic *efx)
        struct tenxpress_phy_data *phy_data = efx->phy_data;
        bool link_ok;
 
-       link_ok = (phy_data->phy_mode == PHY_MODE_NORMAL &&
-                  tenxpress_link_ok(efx, true));
+       link_ok = tenxpress_link_ok(efx, true);
 
        if (link_ok != efx->link_up)
                falcon_xmac_sim_phy_event(efx);