Disable check which fails Vulkan CTS
authorAndrey Tuganov <andreyt@google.com>
Tue, 6 Feb 2018 20:25:03 +0000 (15:25 -0500)
committerDavid Neto <dneto@google.com>
Wed, 7 Feb 2018 18:31:35 +0000 (13:31 -0500)
source/validate_atomics.cpp
test/val/val_atomics_test.cpp

index 108784be29a9734ecd848c35bd3a5979b9f29fb6..8e14e9fea1d77312bee8d2b1491f988efb30ae47 100644 (file)
@@ -43,6 +43,8 @@ spv_result_t ValidateMemoryScope(ValidationState_t& _,
     return SPV_SUCCESS;
   }
 
+#if 0
+  // TODO(atgoo@github.com): this check fails Vulkan CTS, reenable once fixed.
   if (spvIsVulkanEnv(_.context()->target_env)) {
     if (value != SpvScopeDevice && value != SpvScopeWorkgroup &&
         value != SpvScopeInvocation) {
@@ -52,6 +54,7 @@ spv_result_t ValidateMemoryScope(ValidationState_t& _,
                 "Workgroup and Invocation";
     }
   }
+#endif
 
   // TODO(atgoo@github.com) Add checks for OpenCL and OpenGL environments.
 
index 57b6d2f6f0a6b3b36db29c3a7741a1346d7aabcb..44198b3397ab925e151466732756e3ac5edac3af 100644 (file)
@@ -195,7 +195,9 @@ TEST_F(ValidateAtomics, AtomicLoadVulkanSuccess) {
   ASSERT_EQ(SPV_SUCCESS, ValidateInstructions(SPV_ENV_VULKAN_1_0));
 }
 
-TEST_F(ValidateAtomics, AtomicLoadVulkanSubgroup) {
+// TODO(atgoo@github.com): the corresponding check fails Vulkan CTS,
+// reenable once fixed.
+TEST_F(ValidateAtomics, DISABLED_AtomicLoadVulkanSubgroup) {
   const std::string body = R"(
 %val1 = OpAtomicLoad %u32 %u32_var %subgroup %acquire
 )";