bpf: Use thread_group_leader()
authorJonathan Lemon <bsd@fb.com>
Fri, 18 Dec 2020 18:50:31 +0000 (10:50 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 24 Dec 2020 01:04:53 +0000 (02:04 +0100)
Instead of directly comparing task->tgid and task->pid, use the
thread_group_leader() helper.  This helps with readability, and
there should be no functional change.

Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20201218185032.2464558-3-jonathan.lemon@gmail.com
kernel/bpf/task_iter.c

index 8033ab1..dc4007f 100644 (file)
@@ -37,7 +37,7 @@ retry:
                if (!task) {
                        ++*tid;
                        goto retry;
-               } else if (skip_if_dup_files && task->tgid != task->pid &&
+               } else if (skip_if_dup_files && !thread_group_leader(task) &&
                           task->files == task->group_leader->files) {
                        put_task_struct(task);
                        task = NULL;