unifykey: check return value of of_property_read_u32
authorJiamin Ma <jiamin.ma@amlogic.com>
Thu, 31 Aug 2017 01:51:01 +0000 (09:51 +0800)
committerJianxin Pan <jianxin.pan@amlogic.com>
Thu, 14 Sep 2017 10:27:45 +0000 (03:27 -0700)
PD#150092: Calling "of_property_read_u32" without checking return value
driver defect clean up:
#30

Change-Id: I590627fec489e2251c689b9a013d5c792ff19975
Signed-off-by: Jiamin Ma <jiamin.ma@amlogic.com>
drivers/amlogic/unifykey/unifykey_dts.c

index 86e49b9..2fb59c5 100644 (file)
@@ -287,10 +287,13 @@ int unifykey_dt_create(struct platform_device *pdev)
                        __LINE__);
                return ret;
        }
-       /* set default efuse version info */
-       unify_key_info.efuse_version = -1;
-       of_property_read_u32(pdev->dev.of_node, "efuse-version",
+
+       ret = of_property_read_u32(pdev->dev.of_node, "efuse-version",
                &unify_key_info.efuse_version);
+       if (ret != 0) {
+               pr_info("no efuse-version set, use default value: -1\n");
+               unify_key_info.efuse_version = -1;
+       }
 
        pr_info("key unify config unifykey-num is %d\n", key_num);
        unify_key_info.key_num = key_num;