Input: ili210x - remove unneeded suspend and resume handlers
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 4 Nov 2019 23:30:22 +0000 (15:30 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 12 Nov 2019 00:12:26 +0000 (16:12 -0800)
When I2C client is instantiated with I2C_CLIENT_WAKE flag (either via
"wakeup-source" device property, or via board info flag), it will mark the
main IRQ line as wakeup IRQ, which will ensure that it will be enabled for
wakeup when system transitions to suspend state. Since our suspend/resume
handlers were only managing IRQ wakeup state, they are no longer needed,
and can be removed.

Tested-by: Adam Ford <aford173@gmail.com> #imx6q-logicpd
Tested-by: Sven Van Asbroeck <TheSven73@gmail.com> # ILI2118A variant
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/ili210x.c

index ef0da2f..0ed6014 100644 (file)
@@ -446,29 +446,6 @@ static int ili210x_i2c_probe(struct i2c_client *client,
        return 0;
 }
 
-static int __maybe_unused ili210x_i2c_suspend(struct device *dev)
-{
-       struct i2c_client *client = to_i2c_client(dev);
-
-       if (device_may_wakeup(&client->dev))
-               enable_irq_wake(client->irq);
-
-       return 0;
-}
-
-static int __maybe_unused ili210x_i2c_resume(struct device *dev)
-{
-       struct i2c_client *client = to_i2c_client(dev);
-
-       if (device_may_wakeup(&client->dev))
-               disable_irq_wake(client->irq);
-
-       return 0;
-}
-
-static SIMPLE_DEV_PM_OPS(ili210x_i2c_pm,
-                        ili210x_i2c_suspend, ili210x_i2c_resume);
-
 static const struct i2c_device_id ili210x_i2c_id[] = {
        { "ili210x", (long)&ili210x_chip },
        { "ili2117", (long)&ili211x_chip },
@@ -488,7 +465,6 @@ MODULE_DEVICE_TABLE(of, ili210x_dt_ids);
 static struct i2c_driver ili210x_ts_driver = {
        .driver = {
                .name = "ili210x_i2c",
-               .pm = &ili210x_i2c_pm,
                .of_match_table = ili210x_dt_ids,
        },
        .id_table = ili210x_i2c_id,