amdgpu/amdgpu_psp: remove unneeded ret variable
authorMinghao Chi <chi.minghao@zte.com.cn>
Tue, 18 Jan 2022 07:57:02 +0000 (07:57 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 18 Jan 2022 22:43:36 +0000 (17:43 -0500)
Return value from amdgpu_bo_create_kernel() directly instead
of taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

index 5c9b67a..f280695 100644 (file)
@@ -941,19 +941,15 @@ static void psp_prep_ta_load_cmd_buf(struct psp_gfx_cmd_resp *cmd,
 static int psp_ta_init_shared_buf(struct psp_context *psp,
                                  struct ta_mem_context *mem_ctx)
 {
-       int ret;
-
        /*
        * Allocate 16k memory aligned to 4k from Frame Buffer (local
        * physical) for ta to host memory
        */
-       ret = amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size,
+       return amdgpu_bo_create_kernel(psp->adev, mem_ctx->shared_mem_size,
                                      PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM,
                                      &mem_ctx->shared_bo,
                                      &mem_ctx->shared_mc_addr,
                                      &mem_ctx->shared_buf);
-
-       return ret;
 }
 
 static void psp_ta_free_shared_buf(struct ta_mem_context *mem_ctx)