mmc: renesas_sdhi: simplify execute_tuning
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 13 Feb 2020 16:37:15 +0000 (17:37 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 24 Mar 2020 13:39:52 +0000 (14:39 +0100)
After refactoring, 'ret' variable is superfluous. Remove it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20200213163715.8212-1-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi_core.c

index 0f07cc1..df82666 100644 (file)
@@ -497,7 +497,7 @@ static int renesas_sdhi_select_tuning(struct tmio_mmc_host *host)
 static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode)
 {
        struct renesas_sdhi *priv = host_to_priv(host);
-       int i, ret;
+       int i;
 
        priv->tap_num = renesas_sdhi_init_tuning(host);
        if (!priv->tap_num)
@@ -517,8 +517,7 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode)
                /* Set sampling clock position */
                sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_TAPSET, i % priv->tap_num);
 
-               ret = mmc_send_tuning(host->mmc, opcode, NULL);
-               if (ret == 0)
+               if (mmc_send_tuning(host->mmc, opcode, NULL) == 0)
                        set_bit(i, priv->taps);
        }