Fix firstInstance for vkCmdDraw call
authorAlejandro Piñeiro <apinheiro@igalia.com>
Sun, 16 Aug 2020 22:07:23 +0000 (00:07 +0200)
committerAlejandro Piñeiro <apinheiro@igalia.com>
Mon, 17 Aug 2020 00:34:22 +0000 (02:34 +0200)
At vktShaderRender. The tests using that common code doesn't seems to
be setting several instances, but the call to cmddraw is setting first
instance to 1. Note that CmdDraw is called on an else path. The if
codepath is already calling CmdDrawIndexed with firstInstance to 0.

Affects:

dEQP-VK.glsl.builtin_var.simple.pointcoord
dEQP-VK.glsl.builtin_var.simple.pointcoord_uniform_vert
dEQP-VK.glsl.builtin_var.simple.pointcoord_uniform_frag

Components: Vulkan

VK-GL-CTS issue: 2546

Change-Id: Ia608f75e5dbf3879cecf20fd8e0a3a4605c2d2e8

external/vulkancts/modules/vulkan/shaderrender/vktShaderRender.cpp

index e48436a..cb98ba0 100644 (file)
@@ -2264,7 +2264,7 @@ void ShaderRenderCaseInstance::render (deUint32                           numVertices,
                        vk.cmdDrawIndexed(*cmdBuffer, numIndices, 1, 0, 0, 0);
                }
                else
-                       vk.cmdDraw(*cmdBuffer, numVertices,  1, 0, 1);
+                       vk.cmdDraw(*cmdBuffer, numVertices,  1, 0, 0);
 
                endRenderPass(vk, *cmdBuffer);
                endCommandBuffer(vk, *cmdBuffer);