staging: r8188eu: remove unnecessary casting
authorDeepak R Varma <drv@mailo.com>
Sun, 6 Nov 2022 17:57:12 +0000 (23:27 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Nov 2022 15:29:46 +0000 (16:29 +0100)
The dhcpMessage struct member variable "cookie" is already declared
to be of type __be32. There is no need to cast it again as __be32.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/c333e22349c5c347c740b425330b35830b969fa9.1667755987.git.drv@mailo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_br_ext.c

index 4deaa7e..a7c6701 100644 (file)
@@ -615,7 +615,7 @@ void dhcp_flag_bcast(struct adapter *priv, struct sk_buff *skb)
                                if ((udph->source == htons(CLIENT_PORT)) &&
                                    (udph->dest == htons(SERVER_PORT))) { /*  DHCP request */
                                        struct dhcpMessage *dhcph = (void *)udph + sizeof(struct udphdr);
-                                       u32 cookie = be32_to_cpu((__be32)dhcph->cookie);
+                                       u32 cookie = be32_to_cpu(dhcph->cookie);
 
                                        if (cookie == DHCP_MAGIC) { /*  match magic word */
                                                if (!(dhcph->flags & htons(BROADCAST_FLAG))) {