Staging: media: lirc: Merge two lines and remove unused variable
authorMahati Chamarthy <mahati.chamarthy@gmail.com>
Tue, 23 Sep 2014 15:54:47 +0000 (21:24 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Sep 2014 03:31:33 +0000 (20:31 -0700)
This patch merges an assignment with an immediately following return of
the assigned variable. It also removes a variable that becomes unused due to this transformation.
The following Coccinelle semantic patch was used to make this transformation:

@r@
identifier ret;
identifier f;
@@

-ret =
+return
     f(...);
-return ret;

@@
identifier r.ret;
expression e1;
type t;
@@

(
-t ret = e1;
|
-t ret;
)
 ... when != ret
     when strict

Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/media/lirc/lirc_bt829.c

index 3b52f86..4c806ba 100644 (file)
@@ -387,11 +387,9 @@ static unsigned char do_get_bits(void)
 static unsigned int read_index(unsigned char index)
 {
        unsigned char __iomem *addr;
-       unsigned int value;
        /*  addr = pci_addr_lin + DATA_PCI_OFF + ((index & 0xFF) << 2); */
        addr = pci_addr_lin + ((index & 0xFF) << 2);
-       value = readl(addr);
-       return value;
+       return readl(addr);
 }
 
 static void write_index(unsigned char index, unsigned int reg_val)