target: tcm_loop: Improve a size determination in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 10 Dec 2017 20:23:43 +0000 (21:23 +0100)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 12 Jan 2018 23:07:23 +0000 (15:07 -0800)
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/loopback/tcm_loop.c

index 6bd58a0..60e4185 100644 (file)
@@ -769,7 +769,7 @@ static int tcm_loop_make_nexus(
                return -EEXIST;
        }
 
-       tl_nexus = kzalloc(sizeof(struct tcm_loop_nexus), GFP_KERNEL);
+       tl_nexus = kzalloc(sizeof(*tl_nexus), GFP_KERNEL);
        if (!tl_nexus)
                return -ENOMEM;
 
@@ -1076,7 +1076,7 @@ static struct se_wwn *tcm_loop_make_scsi_hba(
        char *ptr;
        int ret, off = 0;
 
-       tl_hba = kzalloc(sizeof(struct tcm_loop_hba), GFP_KERNEL);
+       tl_hba = kzalloc(sizeof(*tl_hba), GFP_KERNEL);
        if (!tl_hba)
                return ERR_PTR(-ENOMEM);