Bluetooth: Fix initializing response id after clearing struct
authorChristopher William Snowhill <chris@kode54.net>
Sun, 27 Dec 2020 03:12:32 +0000 (19:12 -0800)
committerMarcel Holtmann <marcel@holtmann.org>
Sun, 27 Dec 2020 20:35:59 +0000 (21:35 +0100)
Looks like this was missed when patching the source to clear the structures
throughout, causing this one instance to clear the struct after the response
id is assigned.

Fixes: eddb7732119d ("Bluetooth: A2MP: Fix not initializing all members")
Signed-off-by: Christopher William Snowhill <chris@kode54.net>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/a2mp.c

index da7fd7c..cc26e4c 100644 (file)
@@ -381,9 +381,9 @@ static int a2mp_getampassoc_req(struct amp_mgr *mgr, struct sk_buff *skb,
        hdev = hci_dev_get(req->id);
        if (!hdev || hdev->amp_type == AMP_TYPE_BREDR || tmp) {
                struct a2mp_amp_assoc_rsp rsp;
-               rsp.id = req->id;
 
                memset(&rsp, 0, sizeof(rsp));
+               rsp.id = req->id;
 
                if (tmp) {
                        rsp.status = A2MP_STATUS_COLLISION_OCCURED;