usb: phy: tegra: Use switch instead of if-else
authorTuomas Tynkkynen <ttynkkynen@nvidia.com>
Thu, 25 Jul 2013 19:24:09 +0000 (22:24 +0300)
committerFelipe Balbi <balbi@ti.com>
Mon, 29 Jul 2013 12:19:19 +0000 (15:19 +0300)
Use switch() instead of if-else when checking for the PHY type.

Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/phy/phy-tegra-usb.c

index 01c30ff..49fa2da 100644 (file)
@@ -887,11 +887,14 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
                of_property_read_bool(np, "nvidia,has-legacy-mode");
 
        phy_type = of_usb_get_phy_mode(np);
-       if (phy_type == USBPHY_INTERFACE_MODE_UTMI) {
+       switch (phy_type) {
+       case USBPHY_INTERFACE_MODE_UTMI:
                err = utmi_phy_probe(tegra_phy, pdev);
                if (err < 0)
                        return err;
-       } else if (phy_type == USBPHY_INTERFACE_MODE_ULPI) {
+               break;
+
+       case USBPHY_INTERFACE_MODE_ULPI:
                tegra_phy->is_ulpi_phy = true;
 
                tegra_phy->reset_gpio =
@@ -902,7 +905,9 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
                        return tegra_phy->reset_gpio;
                }
                tegra_phy->config = NULL;
-       } else {
+               break;
+
+       default:
                dev_err(&pdev->dev, "phy_type is invalid or unsupported\n");
                return -EINVAL;
        }