spidev: Completely disable the DT warning

The upstream SPI and DT maintainers are completely opposed to declaring
in Device Tree that an SPI CS line is to be managed by the spidev
driver, even though the facility is useful on a hobbyist device like a
Raspberry Pi where arbitrary devices can be attached, and the
alternative to DT declaration (spi_board_info) has been almost entirely
rendered obsolete by DT.

Continue to override their objections by disabling the warning.

See: https://github.com/raspberrypi/linux/issues/3361
     https://github.com/raspberrypi/linux/issues/1054

Signed-off-by: Phil Elwell <phil@raspberrypi.org>

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index c5fe08b..c62ba8f 100644 (file)
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -724,6 +724,7 @@ static int spidev_probe(struct spi_device *spi)
         * compatible string, it is a Linux implementation thing
         * rather than a description of the hardware.
         */
+       if (0) /* Disable the warning - this feature is too useful */
        WARN(spi->dev.of_node &&
             of_device_is_compatible(spi->dev.of_node, "spidev"),
             "%pOF: buggy DT: spidev listed directly in DT\n", spi->dev.of_node);