net: handle ARPHRD_PPP in dev_is_mac_header_xmit()
authorNicolas Dichtel <nicolas.dichtel@6wind.com>
Wed, 23 Aug 2023 13:41:02 +0000 (15:41 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 25 Aug 2023 07:08:27 +0000 (08:08 +0100)
The goal is to support a bpf_redirect() from an ethernet device (ingress)
to a ppp device (egress).
The l2 header is added automatically by the ppp driver, thus the ethernet
header should be removed.

CC: stable@vger.kernel.org
Fixes: 27b29f63058d ("bpf: add bpf_redirect() helper")
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Tested-by: Siwar Zitouni <siwar.zitouni@6wind.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/if_arp.h

index 1ed5244..10a1e81 100644 (file)
@@ -53,6 +53,10 @@ static inline bool dev_is_mac_header_xmit(const struct net_device *dev)
        case ARPHRD_NONE:
        case ARPHRD_RAWIP:
        case ARPHRD_PIMREG:
+       /* PPP adds its l2 header automatically in ppp_start_xmit().
+        * This makes it look like an l3 device to __bpf_redirect() and tcf_mirred_init().
+        */
+       case ARPHRD_PPP:
                return false;
        default:
                return true;