media: atomisp: fix "dubious: !x | !y" sparse warning
authorAnant Thazhemadam <anant.thazhemadam@gmail.com>
Wed, 26 Aug 2020 11:09:15 +0000 (13:09 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 3 Sep 2020 09:05:55 +0000 (11:05 +0200)
Upon running Sparse, "warning: dubious: !x | !y" is brought to notice
for this file.  Logical and bitwise OR are basically the same in this
context, so it doesn't cause a runtime bug.  But let's change it to
logical OR to make it a little bit cleaner and silence the Sparse
warning.

Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c

index 358cb7d..3b850bb 100644 (file)
@@ -58,7 +58,7 @@ sh_css_vf_downscale_log2(
        unsigned int ds_log2 = 0;
        unsigned int out_width;
 
-       if ((!out_info) | (!vf_info))
+       if ((!out_info) || (!vf_info))
                return -EINVAL;
 
        out_width = out_info->res.width;