net: ethernet: remove redundant null pointer check before of_node_put
authorzhong jiang <zhongjiang@huawei.com>
Sun, 16 Sep 2018 13:13:42 +0000 (21:13 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Sep 2018 15:21:45 +0000 (08:21 -0700)
of_node_put has taken the null pointer check into account. So it is
safe to remove the duplicated check before of_node_put.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c

index 2e0bb90..ce74b7a 100644 (file)
@@ -2054,8 +2054,7 @@ static int fec_enet_mii_init(struct platform_device *pdev)
 
        node = of_get_child_by_name(pdev->dev.of_node, "mdio");
        err = of_mdiobus_register(fep->mii_bus, node);
-       if (node)
-               of_node_put(node);
+       of_node_put(node);
        if (err)
                goto err_out_free_mdiobus;