clk: scmi: Free scmi_clk allocated when the clocks with invalid info are skipped
authorSudeep Holla <sudeep.holla@arm.com>
Wed, 4 Oct 2023 19:36:00 +0000 (20:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:59:16 +0000 (11:59 +0100)
[ Upstream commit 3537a75e73f3420614a358d0c8b390ea483cc87d ]

Add the missing devm_kfree() when we skip the clocks with invalid or
missing information from the firmware.

Cc: Cristian Marussi <cristian.marussi@arm.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org
Fixes: 6d6a1d82eaef ("clk: add support for clocks provided by SCMI")
Link: https://lore.kernel.org/r/20231004193600.66232-1-sudeep.holla@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/clk-scmi.c

index 2c7a830..fdec715 100644 (file)
@@ -213,6 +213,7 @@ static int scmi_clocks_probe(struct scmi_device *sdev)
                sclk->info = scmi_proto_clk_ops->info_get(ph, idx);
                if (!sclk->info) {
                        dev_dbg(dev, "invalid clock info for idx %d\n", idx);
+                       devm_kfree(dev, sclk);
                        continue;
                }