This CL relies on: https://skia-review.googlesource.com/c/14186/ (Split up opLists (take 3))
We can't/don't want to close the opList in the GrSurfaceContext dtor because we, semi-often, wrap a proxy in a utility SurfaceContext in order to upload data to it (e.g., when creating a proxy w/ data or in the texture strip atlas).
In the current set up, the "temporary fixes" in newRTOpList and newTextureOpList should prevent any out of order execution.
Change-Id: I8189db6ed59096d7b8c1704028df395f84e4a681
Reviewed-on: https://skia-review.googlesource.com/14187
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
fOpLists[i]->makeClosed(*fContext->caps());
}
+#ifdef SK_DEBUG
+ // This block checks for any unnecessary splits in the opLists. If two sequential opLists
+ // share the same backing GrSurfaceProxy it means the opList was artificially split.
+ if (fOpLists.count()) {
+ GrRenderTargetOpList* prevOpList = fOpLists[0]->asRenderTargetOpList();
+ for (int i = 1; i < fOpLists.count(); ++i) {
+ GrRenderTargetOpList* curOpList = fOpLists[i]->asRenderTargetOpList();
+
+ if (prevOpList && curOpList) {
+ SkASSERT(prevOpList->fTarget.get() != curOpList->fTarget.get());
+ }
+
+ prevOpList = curOpList;
+ }
+ }
+#endif
+
#ifdef ENABLE_MDB
SkDEBUGCODE(bool result =)
SkTTopoSort<GrOpList, GrOpList::TopoSortTraits>(&fOpLists);
#endif
GrRenderTargetContext::~GrRenderTargetContext() {
- if (fOpList) {
- fOpList->makeClosed(*this->caps());
- }
ASSERT_SINGLE_OWNER
}