ice: remove page_reuse statistic
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Thu, 30 Jul 2020 00:19:13 +0000 (17:19 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Sat, 1 Aug 2020 15:43:59 +0000 (08:43 -0700)
The page reuse statistic wasn't even being displayed to the user, even
though the driver counted it. Don't waste the struct space and hot-path
cycles since the driver doesn't display it.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_txrx.c
drivers/net/ethernet/intel/ice/ice_txrx.h

index a508d4f463e9fff151bb62fe580652df9c356685..53c67eeec2fa9ee0f4cea620c4d1320f64e2894f 100644 (file)
@@ -632,7 +632,6 @@ ice_alloc_mapped_page(struct ice_ring *rx_ring, struct ice_rx_buf *bi)
 
        /* since we are recycling buffers we should seldom need to alloc */
        if (likely(page)) {
-               rx_ring->rx_stats.page_reuse_count++;
                return true;
        }
 
@@ -1033,7 +1032,6 @@ static void ice_put_rx_buf(struct ice_ring *rx_ring, struct ice_rx_buf *rx_buf)
        if (ice_can_reuse_rx_page(rx_buf)) {
                /* hand second half of page back to the ring */
                ice_reuse_rx_page(rx_ring, rx_buf);
-               rx_ring->rx_stats.page_reuse_count++;
        } else {
                /* we are not reusing the buffer so unmap it */
                dma_unmap_page_attrs(rx_ring->dev, rx_buf->dma,
index e70c4619edc3063e529299c6e4accb70c0575eb6..77c94daeb434cbb54d630519c7cc9b7dcc881a1a 100644 (file)
@@ -193,7 +193,6 @@ struct ice_rxq_stats {
        u64 non_eop_descs;
        u64 alloc_page_failed;
        u64 alloc_buf_failed;
-       u64 page_reuse_count;
 };
 
 /* this enum matches hardware bits and is meant to be used by DYN_CTLN