ata: ahci_platform: convert kzallloc to kcalloc
authorCorentin Labbe <clabbe@baylibre.com>
Thu, 12 Jul 2018 11:41:30 +0000 (11:41 +0000)
committerTejun Heo <tj@kernel.org>
Thu, 12 Jul 2018 20:02:39 +0000 (13:02 -0700)
It's better to kcalloc instead of kzalloc(n * sizeof())

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libahci_platform.c

index 70052c0..be9f544 100644 (file)
@@ -351,7 +351,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
        struct ahci_host_priv *hpriv;
        struct clk *clk;
        struct device_node *child;
-       int i, sz, enabled_ports = 0, rc = -ENOMEM, child_nodes;
+       int i, enabled_ports = 0, rc = -ENOMEM, child_nodes;
        u32 mask_port_map = 0;
 
        if (!devres_open_group(dev, NULL, GFP_KERNEL))
@@ -403,14 +403,12 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)
        if (!child_nodes)
                hpriv->nports = 1;
 
-       sz = hpriv->nports * sizeof(*hpriv->phys);
-       hpriv->phys = devm_kzalloc(dev, sz, GFP_KERNEL);
+       hpriv->phys = devm_kcalloc(dev, hpriv->nports, sizeof(*hpriv->phys), GFP_KERNEL);
        if (!hpriv->phys) {
                rc = -ENOMEM;
                goto err_out;
        }
-       sz = hpriv->nports * sizeof(*hpriv->target_pwrs);
-       hpriv->target_pwrs = kzalloc(sz, GFP_KERNEL);
+       hpriv->target_pwrs = kcalloc(hpriv->nports, sizeof(*hpriv->target_pwrs), GFP_KERNEL);
        if (!hpriv->target_pwrs) {
                rc = -ENOMEM;
                goto err_out;