sysfb: Make config option dependencies explicit
authorMichal Suchanek <msuchanek@suse.de>
Fri, 25 Feb 2022 20:51:33 +0000 (21:51 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Mar 2022 19:55:20 +0000 (20:55 +0100)
efifb and vesafb requires sysfb implicitly but this is not stated in
Kconfig. Add the dependency.

With that all drivers that require sysfb depend on it so it can default
to disabled.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/a0fa41e9186653e4c41ad0a28259e5cdc71b1f66.1645822213.git.msuchanek@suse.de
drivers/firmware/Kconfig
drivers/video/fbdev/Kconfig

index 75cb910..5265eca 100644 (file)
@@ -218,12 +218,11 @@ config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
 
 config SYSFB
        bool
-       default y
-       depends on X86 || EFI
 
 config SYSFB_SIMPLEFB
        bool "Mark VGA/VBE/EFI FB as generic system framebuffer"
-       depends on SYSFB
+       depends on X86 || EFI
+       select SYSFB
        help
          Firmwares often provide initial graphics framebuffers so the BIOS,
          bootloader or kernel can show basic video-output during boot for
index 6ed5e60..5851ee6 100644 (file)
@@ -628,6 +628,7 @@ config FB_VESA
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        select FB_BOOT_VESA_SUPPORT
+       select SYSFB
        help
          This is the frame buffer device driver for generic VESA 2.0
          compliant graphic cards. The older VESA 1.2 cards are not supported.
@@ -641,6 +642,7 @@ config FB_EFI
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
+       select SYSFB
        help
          This is the EFI frame buffer device driver. If the firmware on
          your platform is EFI 1.10 or UEFI 2.0, select Y to add support for