sbi: sbi_pmu: Add hw_counter_filter_mode() to pmu device
authorYu Chien Peter Lin <peterlin@andestech.com>
Thu, 30 Nov 2023 12:42:02 +0000 (20:42 +0800)
committerAnup Patel <anup@brainfault.org>
Wed, 6 Dec 2023 12:00:01 +0000 (17:30 +0530)
Add support for custom PMU extensions to set inhibit bits
on custom CSRs by introducing the PMU device callback
hw_counter_filter_mode(). This allows the perf tool to
restrict event counting under a specified privileged
mode by appending a modifier, e.g. perf record -e event:k
to count events only happening in kernel mode.

Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
include/sbi/sbi_pmu.h
lib/sbi/sbi_pmu.c

index 16f687733baabf2c20290c44775496040b67756c..d63149cde8ad22716f0d90b34f13a9dfb9de73b4 100644 (file)
@@ -89,6 +89,12 @@ struct sbi_pmu_device {
         * Custom function returning the machine-specific irq-bit.
         */
        int (*hw_counter_irq_bit)(void);
+
+       /**
+        * Custom function to inhibit counting of events while in
+        * specified mode.
+        */
+       void (*hw_counter_filter_mode)(unsigned long flags, int counter_index);
 };
 
 /** Get the PMU platform device */
index 2ee6e62a8f9f8fe164fbd9f699a1c20d82a927d6..4b0f5be4bf71a2b3ea3358d0294cb2c307d8e5e7 100644 (file)
@@ -599,7 +599,10 @@ static int pmu_update_hw_mhpmevent(struct sbi_pmu_hw_event *hw_evt, int ctr_idx,
                pmu_dev->hw_counter_disable_irq(ctr_idx);
 
        /* Update the inhibit flags based on inhibit flags received from supervisor */
-       pmu_update_inhibit_flags(flags, &mhpmevent_val);
+       if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SSCOFPMF))
+               pmu_update_inhibit_flags(flags, &mhpmevent_val);
+       if (pmu_dev && pmu_dev->hw_counter_filter_mode)
+               pmu_dev->hw_counter_filter_mode(flags, ctr_idx);
 
 #if __riscv_xlen == 32
        csr_write_num(CSR_MHPMEVENT3 + ctr_idx - 3, mhpmevent_val & 0xFFFFFFFF);
@@ -620,7 +623,8 @@ static int pmu_fixed_ctr_update_inhibit_bits(int fixed_ctr, unsigned long flags)
 #if __riscv_xlen == 32
        uint64_t cfgh_csr_no;
 #endif
-       if (!sbi_hart_has_extension(scratch, SBI_HART_EXT_SMCNTRPMF))
+       if (!sbi_hart_has_extension(scratch, SBI_HART_EXT_SMCNTRPMF) &&
+               !(pmu_dev && pmu_dev->hw_counter_filter_mode))
                return fixed_ctr;
 
        switch (fixed_ctr) {
@@ -641,13 +645,17 @@ static int pmu_fixed_ctr_update_inhibit_bits(int fixed_ctr, unsigned long flags)
        }
 
        cfg_val |= MHPMEVENT_MINH;
-       pmu_update_inhibit_flags(flags, &cfg_val);
+       if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SMCNTRPMF)) {
+               pmu_update_inhibit_flags(flags, &cfg_val);
 #if __riscv_xlen == 32
-       csr_write_num(cfg_csr_no, cfg_val & 0xFFFFFFFF);
-       csr_write_num(cfgh_csr_no, cfg_val >> BITS_PER_LONG);
+               csr_write_num(cfg_csr_no, cfg_val & 0xFFFFFFFF);
+               csr_write_num(cfgh_csr_no, cfg_val >> BITS_PER_LONG);
 #else
-       csr_write_num(cfg_csr_no, cfg_val);
+               csr_write_num(cfg_csr_no, cfg_val);
 #endif
+       }
+       if (pmu_dev && pmu_dev->hw_counter_filter_mode)
+               pmu_dev->hw_counter_filter_mode(flags, fixed_ctr);
        return fixed_ctr;
 }