scsi: ufs: ufshcd-pltfrm: Constify pointed data
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 23 Jun 2022 10:24:31 +0000 (12:24 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 28 Jun 2022 02:26:45 +0000 (22:26 -0400)
For code safety, constify pointers to data which is not modified.

Link: https://lore.kernel.org/r/20220623102432.108059-3-krzysztof.kozlowski@linaro.org
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufshcd-pltfrm.c
drivers/ufs/host/ufshcd-pltfrm.h

index 2dd9c66..bde3468 100644 (file)
@@ -26,7 +26,7 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)
        int i;
        struct device *dev = hba->dev;
        struct device_node *np = dev->of_node;
-       char *name;
+       const char *name;
        u32 *clkfreq = NULL;
        struct ufs_clk_info *clki;
        int len = 0;
@@ -79,8 +79,8 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)
        }
 
        for (i = 0; i < sz; i += 2) {
-               ret = of_property_read_string_index(np,
-                               "clock-names", i/2, (const char **)&name);
+               ret = of_property_read_string_index(np, "clock-names", i/2,
+                                                   &name);
                if (ret)
                        goto out;
 
@@ -209,8 +209,8 @@ static void ufshcd_init_lanes_per_dir(struct ufs_hba *hba)
  *
  * Returns 0 on success, non-zero value on failure
  */
-int ufshcd_get_pwr_dev_param(struct ufs_dev_params *pltfrm_param,
-                            struct ufs_pa_layer_attr *dev_max,
+int ufshcd_get_pwr_dev_param(const struct ufs_dev_params *pltfrm_param,
+                            const struct ufs_pa_layer_attr *dev_max,
                             struct ufs_pa_layer_attr *agreed_pwr)
 {
        int min_pltfrm_gear;
index 5130c94..2e4ba2b 100644 (file)
@@ -25,8 +25,8 @@ struct ufs_dev_params {
        u32 desired_working_mode;
 };
 
-int ufshcd_get_pwr_dev_param(struct ufs_dev_params *dev_param,
-                            struct ufs_pa_layer_attr *dev_max,
+int ufshcd_get_pwr_dev_param(const struct ufs_dev_params *dev_param,
+                            const struct ufs_pa_layer_attr *dev_max,
                             struct ufs_pa_layer_attr *agreed_pwr);
 void ufshcd_init_pwr_dev_param(struct ufs_dev_params *dev_param);
 int ufshcd_pltfrm_init(struct platform_device *pdev,