phy: cadence-torrent: use swap() to make code cleaner
authorYang Guang <yang.guang5@zte.com.cn>
Thu, 4 Nov 2021 06:52:33 +0000 (14:52 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Nov 2021 05:54:30 +0000 (11:24 +0530)
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Link: https://lore.kernel.org/r/20211104065233.1833499-1-yang.guang5@zte.com.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/cadence/phy-cadence-torrent.c

index 5786166..7c4b805 100644 (file)
@@ -2278,7 +2278,7 @@ int cdns_torrent_phy_configure_multilink(struct cdns_torrent_phy *cdns_phy)
        struct cdns_torrent_vals *cmn_vals, *tx_ln_vals, *rx_ln_vals;
        enum cdns_torrent_ref_clk ref_clk = cdns_phy->ref_clk_rate;
        struct cdns_torrent_vals *link_cmn_vals, *xcvr_diag_vals;
-       enum cdns_torrent_phy_type phy_t1, phy_t2, tmp_phy_type;
+       enum cdns_torrent_phy_type phy_t1, phy_t2;
        struct cdns_torrent_vals *pcs_cmn_vals;
        int i, j, node, mlane, num_lanes, ret;
        struct cdns_reg_pairs *reg_pairs;
@@ -2304,9 +2304,7 @@ int cdns_torrent_phy_configure_multilink(struct cdns_torrent_phy *cdns_phy)
                         * configure the PHY for second link with phy_t2.
                         * Get the array values as [phy_t2][phy_t1][ssc].
                         */
-                       tmp_phy_type = phy_t1;
-                       phy_t1 = phy_t2;
-                       phy_t2 = tmp_phy_type;
+                       swap(phy_t1, phy_t2);
                }
 
                mlane = cdns_phy->phys[node].mlane;