pinctrl: samsung: Explicitly cast pointer returned by of_iomap() to iomem
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 23 May 2017 18:36:53 +0000 (20:36 +0200)
committerKrzysztof Kozlowski <krzk@kernel.org>
Wed, 7 Jun 2017 18:40:48 +0000 (20:40 +0200)
For S5Pv210 retention control, the driver stores the iomem pointer from
of_iomap() under a void pointer member.  This makes sparse unhappy:

    drivers/pinctrl/samsung/pinctrl-exynos.c:664:36: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/samsung/pinctrl-exynos.c:664:36:    expected void const volatile [noderef] <asn:2>*addr
    drivers/pinctrl/samsung/pinctrl-exynos.c:664:36:    got void *

The iomem pointer is used safely (stored under priv by
s5pv210_retention_init(), used by s5pv210_retention_disable()) thus we
can add explicit casts to iomem to silence the warning.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/pinctrl/samsung/pinctrl-exynos-arm.c

index 62e1cc3..071084d 100644 (file)
@@ -47,7 +47,7 @@ static const struct samsung_pin_bank_type bank_type_alive = {
 
 static void s5pv210_retention_disable(struct samsung_pinctrl_drv_data *drvdata)
 {
-       void *clk_base = drvdata->retention_ctrl->priv;
+       void __iomem *clk_base = (void __iomem *)drvdata->retention_ctrl->priv;
        u32 tmp;
 
        tmp = __raw_readl(clk_base + S5P_OTHERS);
@@ -62,7 +62,7 @@ s5pv210_retention_init(struct samsung_pinctrl_drv_data *drvdata,
 {
        struct samsung_retention_ctrl *ctrl;
        struct device_node *np;
-       void *clk_base;
+       void __iomem *clk_base;
 
        ctrl = devm_kzalloc(drvdata->dev, sizeof(*ctrl), GFP_KERNEL);
        if (!ctrl)
@@ -81,7 +81,7 @@ s5pv210_retention_init(struct samsung_pinctrl_drv_data *drvdata,
                return ERR_PTR(-EINVAL);
        }
 
-       ctrl->priv = clk_base;
+       ctrl->priv = (void __force *)clk_base;
        ctrl->disable = s5pv210_retention_disable;
 
        return ctrl;