staging: wilc1000: remove the use of goto label in wilc_spi_clear_int_ext()
authorAjay Singh <ajay.kathat@microchip.com>
Mon, 23 Apr 2018 16:33:34 +0000 (22:03 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Apr 2018 13:54:16 +0000 (15:54 +0200)
Remove goto label '_fail_' used in wilc_spi_clear_int_ext(), to avoid
the label name starting with '_'.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/wilc_spi.c

index 1db2814..2cb9f4e 100644 (file)
@@ -1013,7 +1013,7 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val)
                        dev_err(&spi->dev,
                                "Failed wilc_spi_write_reg, set reg %x ...\n",
                                0x10c8 + i * 4);
-                       goto _fail_;
+                       return ret;
                }
                for (i = g_spi.nint; i < MAX_NUM_INT; i++) {
                        if (flags & 1)
@@ -1035,7 +1035,7 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val)
        ret = wilc_spi_write_reg(wilc, WILC_VMM_TBL_CTL, tbl_ctl);
        if (!ret) {
                dev_err(&spi->dev, "fail write reg vmm_tbl_ctl...\n");
-               goto _fail_;
+               return ret;
        }
 
        if ((val & EN_VMM) == EN_VMM) {
@@ -1045,10 +1045,10 @@ static int wilc_spi_clear_int_ext(struct wilc *wilc, u32 val)
                ret = wilc_spi_write_reg(wilc, WILC_VMM_CORE_CTL, 1);
                if (!ret) {
                        dev_err(&spi->dev, "fail write reg vmm_core_ctl...\n");
-                       goto _fail_;
+                       return ret;
                }
        }
-_fail_:
+
        return ret;
 }