FIX NEGATIVE_RETURNS & UNUSED_VALUE detect

Change-Id: I18ea1998dd00a3aa0efbd038136ca26e746795b4
Signed-off-by: Le <xuan.tien@samsung.com>

diff --git a/tests/pkcs12/new_test_cases.cpp b/tests/pkcs12/new_test_cases.cpp
index 495efe5270069d2c524665aecb6add05e6532bcf..c88801023b29231d0d5a59a009f3cae0ad39ee57 100644 (file)
--- a/tests/pkcs12/new_test_cases.cpp
+++ b/tests/pkcs12/new_test_cases.cpp
@@ -903,6 +903,7 @@ RUNNER_TEST(CERTSVC_PKCS12_1027_get_alias_name_from_gname_from_store)
                fp = fopen(privatekey_path, "w");
                RUNNER_ASSERT_MSG(fp != NULL, "Failed to open the file for writing");
                result = PEM_write_PrivateKey(fp, privatekey, NULL, NULL, 0, NULL, NULL);
+               RUNNER_ASSERT_MSG(result != 0, "Failed to write private key onto file.");
                fclose(fp);
                certsvc_pkcs12_free_evp_pkey(privatekey);
                certsvc_string_free(Alias);

diff --git a/unit-tests/test_dpl_old_style_log_provider.cpp b/unit-tests/test_dpl_old_style_log_provider.cpp
index 438c93c883f67a42aac4e5ea231ff150e14beefb..5a074bd3d0084e4eb66740828fedd3cd01bb3f95 100644 (file)
--- a/unit-tests/test_dpl_old_style_log_provider.cpp
+++ b/unit-tests/test_dpl_old_style_log_provider.cpp
@@ -47,12 +47,18 @@ string getLogFromCmd(
 
        oldStyleLogProvider->Log(level, message, __FILE__, line, function);
 
+       if (saved_stdout < 0)
+               return "";
+
        dup2(saved_stdout, STDOUT_FILENO);
        close(saved_stdout);
 
        char buffer[1 << 10];
        ssize_t count = read(pipefd[0], buffer, sizeof(buffer) - 1);
-       buffer[count] = '\0';
+       if (count >= 0)
+               buffer[count] = '\0';
+       else
+               return "";
 
        close(pipefd[0]);