Improve error handling when copying extension name

The extension list now calls abort() if an extension name exceeding
the length limit is copied.

Change-Id: I105946b647ebd0087dc892d7c8a227628da31966
Signed-off-by: Fufu Fang <fufu.fang@arm.com>

diff --git a/util/extension_list.cpp b/util/extension_list.cpp
index ec2184d938cdb4b7f21898b1015209403d471119..fd857c2f9c1e35d878bd4a5cce94d8d06e0d8eef 100644 (file)
--- a/util/extension_list.cpp
+++ b/util/extension_list.cpp
@@ -47,12 +47,11 @@ VkResult extension_list::add(const char *const *extensions, uint32_t count)
    for (uint32_t i = 0; i < count; i++)
    {
       auto &dst = m_ext_props[initial_size + i];
-      strncpy(dst.extensionName, extensions[i], sizeof(dst.extensionName));
-
       if (strlen(extensions[i]) >= sizeof(dst.extensionName))
       {
-         dst.extensionName[sizeof(dst.extensionName) - 1] = '\0';
+         abort();
       }
+      strcpy(dst.extensionName, extensions[i]);
    }
    return VK_SUCCESS;
 }