Summary:
elput: fix warning for unused write result
ecore_con: fix warning for unused asprintf result
Reviewers: iscaro, devilhorns, cedric
Reviewed By: cedric
Subscribers: cedric, seoz, jpeg
Differential Revision: https://phab.enlightenment.org/D4308
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
* parameter must be a URL with schema, otherwise it won't
* return anything.
*/
- char *url;
+ Eina_Stringshare *url;
- asprintf(&url, "%s://%s:%s", d->protocol == IPPROTO_UDP ? "udp" : "tcp", host, port);
- proxies = ecore_con_libproxy_proxies_get(url);
- free(url);
+ url = eina_stringshare_printf("%s://%s:%s", d->protocol == IPPROTO_UDP ? "udp" : "tcp", host, port);
+ if (!url)
+ {
+ ERR("Could not assemble URL");
+ }
+ else
+ {
+ proxies = ecore_con_libproxy_proxies_get(url);
+ eina_stringshare_del(url);
+ }
}
EINA_THREAD_CLEANUP_PUSH((Eina_Free_Cb)ecore_con_libproxy_proxies_free, proxies);
static void
_logind_pipe_write_fd(Elput_Manager *em, int fd)
{
- write(em->input.pipe, &fd, sizeof(int));
+ int ret;
+
+ while (1)
+ {
+ ret = write(em->input.pipe, &fd, sizeof(int));
+ if (ret < 0)
+ {
+ if ((errno == EAGAIN) || (errno == EINTR))
+ continue;
+ WRN("Failed to write to input pipe");
+ }
+ break;
+ }
close(em->input.pipe);
em->input.pipe = -1;
}