ASoC: SOF: Intel: hda: reset link DMA state in prepare

When application goes through SUSPEND/STOP->PREPARE->START
cycle, we should always reprogram the DAI link DMA to ensure
it is in sync with the host PCM DMA.

Use same state tracking logic to handle both restart and
system resume flows. Use link_prepared field of
'struct hdac_ext_stream' to store the state, instead of
adding redundant fields to SOF specific structs.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20190722141402.7194-18-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c
index a514f9cf5c9a1bf982cc7308bacb62235aad4761..a448be60f6ddf14330ab121b5c5d6ce701af2e8c 100644 (file)
--- a/sound/soc/sof/intel/hda-dai.c
+++ b/sound/soc/sof/intel/hda-dai.c
@@ -226,8 +226,6 @@ static int hda_link_hw_params(struct snd_pcm_substream *substream,
 
        snd_soc_dai_set_dma_data(dai, substream, (void *)link_dev);
 
-       hda_stream->hw_params_upon_resume = 0;
-
        link = snd_hdac_ext_bus_get_link(bus, codec_dai->component->name);
        if (!link)
                return -EINVAL;
@@ -267,8 +265,7 @@ static int hda_link_pcm_prepare(struct snd_pcm_substream *substream,
 
        hda_stream = hstream_to_sof_hda_stream(link_dev);
 
-       /* setup hw_params again only if resuming from system suspend */
-       if (!hda_stream->hw_params_upon_resume)
+       if (link_dev->link_prepared)
                return 0;
 
        dev_dbg(sdev->dev, "hda: prepare stream dir %d\n", substream->stream);
@@ -317,6 +314,7 @@ static int hda_link_pcm_trigger(struct snd_pcm_substream *substream,
                snd_hdac_ext_link_stream_start(link_dev);
                break;
        case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_STOP:
                /*
                 * clear and release link DMA channel. It will be assigned when
                 * hw_params is set up again after resume.
@@ -329,10 +327,10 @@ static int hda_link_pcm_trigger(struct snd_pcm_substream *substream,
                snd_hdac_ext_link_clear_stream_id(link, stream_tag);
                snd_hdac_ext_stream_release(link_dev,
                                            HDAC_EXT_STREAM_TYPE_LINK);
+               link_dev->link_prepared = 0;
 
                /* fallthrough */
        case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
-       case SNDRV_PCM_TRIGGER_STOP:
                snd_hdac_ext_link_stream_clear(link_dev);
                break;
        default:

diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index f08a5d649346c4087bdf7171cb89b369bd43f0f1..e82ecaad1763e95dd578f89b9f6e5952e4fd2a09 100644 (file)
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -425,25 +425,19 @@ int hda_dsp_suspend(struct snd_sof_dev *sdev)
 
 int hda_dsp_set_hw_params_upon_resume(struct snd_sof_dev *sdev)
 {
-       struct hdac_bus *bus = sof_to_bus(sdev);
-       struct sof_intel_hda_stream *hda_stream;
-       struct hdac_ext_stream *stream;
-       struct hdac_stream *s;
-
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
+       struct hdac_bus *bus = sof_to_bus(sdev);
        struct snd_soc_pcm_runtime *rtd;
+       struct hdac_ext_stream *stream;
        struct hdac_ext_link *link;
+       struct hdac_stream *s;
        const char *name;
        int stream_tag;
-#endif
 
        /* set internal flag for BE */
        list_for_each_entry(s, &bus->stream_list, list) {
                stream = stream_to_hdac_ext_stream(s);
-               hda_stream = container_of(stream, struct sof_intel_hda_stream,
-                                         hda_stream);
-               hda_stream->hw_params_upon_resume = 1;
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
+
                /*
                 * clear and release stream. This should already be taken care
                 * for running streams when the SUSPEND trigger is called.
@@ -460,8 +454,9 @@ int hda_dsp_set_hw_params_upon_resume(struct snd_sof_dev *sdev)
                        snd_hdac_ext_link_clear_stream_id(link, stream_tag);
                        snd_hdac_ext_stream_release(stream,
                                                    HDAC_EXT_STREAM_TYPE_LINK);
+                       stream->link_prepared = 0;
                }
-#endif
        }
+#endif
        return 0;
 }

diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h
index 028e865d5e20586cda044effd1082bdb7f262f97..ceaaa8d467f4cfed50def139f52ea2924e08d7b6 100644 (file)
--- a/sound/soc/sof/intel/hda.h
+++ b/sound/soc/sof/intel/hda.h
@@ -418,7 +418,6 @@ struct sof_intel_hda_stream {
        struct snd_sof_dev *sdev;
        struct hdac_ext_stream hda_stream;
        struct sof_intel_stream stream;
-       int hw_params_upon_resume; /* set up hw_params upon resume */
        int host_reserved; /* reserve host DMA channel */
 };