nfctool: Fix llcp-decode potential overflow
authorSamuel Ortiz <sameo@linux.intel.com>
Mon, 4 Nov 2013 23:47:25 +0000 (00:47 +0100)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 20 Nov 2013 00:06:26 +0000 (01:06 +0100)
Code review done by Sebastian Krahmer <krahmer@suse.de>.

tools/nfctool/llcp-decode.c

index 8704873..7f95640 100644 (file)
@@ -268,7 +268,7 @@ static void llcp_print_params(struct sniffer_packet *packet)
                case LLCP_PARAM_SN:
                        sn = g_strndup((gchar *)param + 2, param_len);
                        llcp_add_connection_sn(packet, sn);
-                       sprintf(param_str, "%s", sn);
+                       snprintf(param_str, 64, "%s", sn);
                        g_free(sn);
                        break;
 
@@ -279,7 +279,7 @@ static void llcp_print_params(struct sniffer_packet *packet)
                case LLCP_PARAM_SDREQ:
                        tid = param[2];
                        sn = g_strndup((gchar *)param + 3, param_len - 1);
-                       sprintf(param_str, "TID:%d, SN:%s", tid, sn);
+                       snprintf(param_str, 64, "TID:%d, SN:%s", tid, sn);
                        g_free(sn);
                        break;