mtd: rfd_ftl: add discard support

I proposed this change 16 years ago before discard was a feature in
the block layer: https://lwn.net/Articles/162776/

Now that the block layer has discard, we can finally merge this change.

Discard is also known as trim. By implementing discard, both fstrim and
the discard filesystem option can be used.

Implementing discard in the ftl means that when files are removed, there
is less data in the ftl mapping. This means less stuff to move around for
erasing and also less erasing to do; this means improved wear levelling
and improved performance.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210807214538.14484-3-sean@mess.org

diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 7b243f2..7f5f6d2 100644 (file)
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -705,6 +705,34 @@ err:
        return rc;
 }
 
+static int rfd_ftl_discardsect(struct mtd_blktrans_dev *dev,
+                              unsigned long sector, unsigned int nr_sects)
+{
+       struct partition *part = (struct partition *)dev;
+       u_long addr;
+       int rc;
+
+       while (nr_sects) {
+               if (sector >= part->sector_count)
+                       return -EIO;
+
+               addr = part->sector_map[sector];
+
+               if (addr != -1) {
+                       rc = mark_sector_deleted(part, addr);
+                       if (rc)
+                               return rc;
+
+                       part->sector_map[sector] = -1;
+               }
+
+               sector++;
+               nr_sects--;
+       }
+
+       return 0;
+}
+
 static int rfd_ftl_getgeo(struct mtd_blktrans_dev *dev, struct hd_geometry *geo)
 {
        struct partition *part = (struct partition*)dev;
@@ -786,6 +814,7 @@ static struct mtd_blktrans_ops rfd_ftl_tr = {
 
        .readsect       = rfd_ftl_readsect,
        .writesect      = rfd_ftl_writesect,
+       .discard        = rfd_ftl_discardsect,
        .getgeo         = rfd_ftl_getgeo,
        .add_mtd        = rfd_ftl_add_mtd,
        .remove_dev     = rfd_ftl_remove_dev,