PR target/108589 - Check REG_P for AARCH64_FUSE_ADDSUB_2REG_CONST1
authorPhilipp Tomsich <philipp.tomsich@vrull.eu>
Mon, 30 Jan 2023 22:40:26 +0000 (23:40 +0100)
committerPhilipp Tomsich <philipp.tomsich@vrull.eu>
Tue, 31 Jan 2023 15:34:28 +0000 (16:34 +0100)
This adds a check for REG_P on SET_DEST for the new idiom recognizer
for AARCH64_FUSE_ADDSUB_2REG_CONST1.  The reported ICE is only
observable with checking=rtl.

Bootstrapped/regtested aarch64-linux, committed.

PR target/108589

gcc/ChangeLog:

* config/aarch64/aarch64.cc (aarch_macro_fusion_pair_p): Check
REG_P on SET_DEST.

gcc/testsuite/ChangeLog:

* gcc.target/aarch64/pr108589.c: New test.

gcc/config/aarch64/aarch64.cc
gcc/testsuite/gcc.target/aarch64/pr108589.c [new file with mode: 0644]

index 17c1e23..acc0cfe 100644 (file)
@@ -25704,6 +25704,7 @@ aarch_macro_fusion_pair_p (rtx_insn *prev, rtx_insn *curr)
          && CONST_INT_P (XEXP (curr_src, 1))
          && INTVAL (XEXP (curr_src, 1)) == polarity
          && REG_P (XEXP (curr_src, 0))
+         && REG_P (SET_DEST (prev_set))
          && REGNO (SET_DEST (prev_set)) == REGNO (XEXP (curr_src, 0)))
        return true;
     }
diff --git a/gcc/testsuite/gcc.target/aarch64/pr108589.c b/gcc/testsuite/gcc.target/aarch64/pr108589.c
new file mode 100644 (file)
index 0000000..861727f
--- /dev/null
@@ -0,0 +1,15 @@
+/* { dg-do compile } */
+/* { dg-require-effective-target lp64 } */
+/* { dg-options "-Os -O2 -mtune=ampere1a -fno-split-wide-types" } */
+
+int i;
+__int128 j;
+short s;
+
+void
+foo (void)
+{
+  j -= i;
+  int l = i - __builtin_sub_overflow_p (0, 61680, s);
+  j -= __builtin_mul_overflow_p (i, l, 0);
+}