ASoC: imx-audmux: use sysfs_emit() to instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Mon, 5 Dec 2022 11:43:47 +0000 (19:43 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 7 Dec 2022 14:19:14 +0000 (14:19 +0000)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212051943476482106@zte.com.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/imx-audmux.c

index 50b71e5..582f1e2 100644 (file)
@@ -75,8 +75,7 @@ static ssize_t audmux_read_file(struct file *file, char __user *user_buf,
        if (!buf)
                return -ENOMEM;
 
-       ret = scnprintf(buf, PAGE_SIZE, "PDCR: %08x\nPTCR: %08x\n",
-                      pdcr, ptcr);
+       ret = sysfs_emit(buf, "PDCR: %08x\nPTCR: %08x\n", pdcr, ptcr);
 
        if (ptcr & IMX_AUDMUX_V2_PTCR_TFSDIR)
                ret += scnprintf(buf + ret, PAGE_SIZE - ret,