leds-lp5523: set the brightness to 0 forcely on removing the driver
authorKim, Milo <Milo.Kim@ti.com>
Wed, 22 Aug 2012 07:32:45 +0000 (15:32 +0800)
committerBryan Wu <bryan.wu@canonical.com>
Tue, 11 Sep 2012 10:32:41 +0000 (18:32 +0800)
Turning off the brightness of each channel is required
when removing the driver.

So use flush_work() rather than cancel_work_sync() to execute
remaining brightness works.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
drivers/leds/leds-lp5523.c

index 9fd9a92..2fd5689 100644 (file)
@@ -974,7 +974,7 @@ static int __devinit lp5523_probe(struct i2c_client *client,
 fail2:
        for (i = 0; i < chip->num_leds; i++) {
                led_classdev_unregister(&chip->leds[i].cdev);
-               cancel_work_sync(&chip->leds[i].brightness_work);
+               flush_work(&chip->leds[i].brightness_work);
        }
 fail1:
        if (pdata->enable)
@@ -993,7 +993,7 @@ static int lp5523_remove(struct i2c_client *client)
 
        for (i = 0; i < chip->num_leds; i++) {
                led_classdev_unregister(&chip->leds[i].cdev);
-               cancel_work_sync(&chip->leds[i].brightness_work);
+               flush_work(&chip->leds[i].brightness_work);
        }
 
        if (chip->pdata->enable)