cifs: set correct ipc status after initial tree connect
authorPaulo Alcantara <pc@cjr.nz>
Fri, 16 Dec 2022 17:00:19 +0000 (14:00 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Jan 2023 10:11:50 +0000 (11:11 +0100)
commit 86fe0fa8747fb1bc4cc44fc1966e0959fe752f38 upstream.

cifs_tcon::status wasn't correctly updated to TID_GOOD after
establishing initial IPC connection thus staying at TID_NEW as long as
it wasn't reconnected.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/connect.c

index 191fc13..0d0e173 100644 (file)
@@ -1871,6 +1871,9 @@ cifs_setup_ipc(struct cifs_ses *ses, struct smb3_fs_context *ctx)
 
        cifs_dbg(FYI, "IPC tcon rc=%d ipc tid=0x%x\n", rc, tcon->tid);
 
+       spin_lock(&tcon->tc_lock);
+       tcon->status = TID_GOOD;
+       spin_unlock(&tcon->tc_lock);
        ses->tcon_ipc = tcon;
 out:
        return rc;
@@ -2280,10 +2283,10 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb3_fs_context *ctx)
        list_add(&ses->smb_ses_list, &server->smb_ses_list);
        spin_unlock(&cifs_tcp_ses_lock);
 
-       free_xid(xid);
-
        cifs_setup_ipc(ses, ctx);
 
+       free_xid(xid);
+
        return ses;
 
 get_ses_fail: