gpio: altera-a10sr: remove redundant of_match_ptr
authorZhu Wang <wangzhu9@huawei.com>
Wed, 2 Aug 2023 02:24:03 +0000 (10:24 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 3 Aug 2023 13:58:45 +0000 (15:58 +0200)
The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it. Hence we remove of_match_ptr().

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-altera-a10sr.c

index be1ed7e..11edf1f 100644 (file)
@@ -9,6 +9,7 @@
 
 #include <linux/gpio/driver.h>
 #include <linux/mfd/altera-a10sr.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/property.h>
 
@@ -104,7 +105,7 @@ static struct platform_driver altr_a10sr_gpio_driver = {
        .probe = altr_a10sr_gpio_probe,
        .driver = {
                .name   = "altr_a10sr_gpio",
-               .of_match_table = of_match_ptr(altr_a10sr_gpio_of_match),
+               .of_match_table = altr_a10sr_gpio_of_match,
        },
 };
 module_platform_driver(altr_a10sr_gpio_driver);