selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported
authorFenghua Yu <fenghua.yu@intel.com>
Wed, 17 Mar 2021 02:22:46 +0000 (02:22 +0000)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 2 Apr 2021 19:57:49 +0000 (13:57 -0600)
check_resctrlfs_support() does the following
1. Checks if the platform supports resctrl file system or not by looking
   for resctrl in /proc/filesystems
2. Calls opendir() on default resctrl file system path
   (i.e. /sys/fs/resctrl)
3. Checks if resctrl file system is mounted or not by looking at
   /proc/mounts

Steps 2 and 3 will fail if the platform does not support resctrl file
system. So, there is no need to check for them if step 1 fails.

Fix this by returning immediately if the platform does not support
resctrl file system.

Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/resctrl/resctrlfs.c

index 6b22a18..87195eb 100644 (file)
@@ -570,6 +570,9 @@ bool check_resctrlfs_support(void)
        ksft_print_msg("%s kernel supports resctrl filesystem\n",
                       ret ? "Pass:" : "Fail:");
 
+       if (!ret)
+               return ret;
+
        dp = opendir(RESCTRL_PATH);
        ksft_print_msg("%s resctrl mountpoint \"%s\" exists\n",
                       dp ? "Pass:" : "Fail:", RESCTRL_PATH);