net: ieee802154: forbid monitor for add llsec devkey
authorAlexander Aring <aahringo@redhat.com>
Mon, 5 Apr 2021 00:30:49 +0000 (20:30 -0400)
committerStefan Schmidt <stefan@datenfreihafen.org>
Tue, 6 Apr 2021 20:24:08 +0000 (22:24 +0200)
This patch forbids to add llsec devkey for monitor interfaces which we
don't support yet. Otherwise we will access llsec mib which isn't
initialized for monitors.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210405003054.256017-11-aahringo@redhat.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
net/ieee802154/nl802154.c

index 6f9cb6c0cafc4cb14a54149284bdc06f1d7468b0..c3f9bff7a5572b01f0c471be6b53aa55f62f344a 100644 (file)
@@ -1915,6 +1915,9 @@ static int nl802154_add_llsec_devkey(struct sk_buff *skb, struct genl_info *info
        struct ieee802154_llsec_device_key key;
        __le64 extended_addr;
 
+       if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR)
+               return -EOPNOTSUPP;
+
        if (!info->attrs[NL802154_ATTR_SEC_DEVKEY] ||
            nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack) < 0)
                return -EINVAL;