drm/i915/icl: Fix power well 2 wrt. DC-off toggling order
authorImre Deak <imre.deak@intel.com>
Fri, 2 Nov 2018 18:22:00 +0000 (20:22 +0200)
committerImre Deak <imre.deak@intel.com>
Wed, 7 Nov 2018 20:19:24 +0000 (22:19 +0200)
To enable DC5/6 power well 2 has to be disabled as for previous
platforms, so fix things up.

Bspec: 4234
Fixes: 67ca07e7ac10 ("drm/i915/icl: Add power well support")
Cc: Animesh Manna <animesh.manna@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181102182200.17219-1-imre.deak@intel.com
drivers/gpu/drm/i915/intel_runtime_pm.c

index 6c45336..cda73bf 100644 (file)
@@ -2791,6 +2791,12 @@ static const struct i915_power_well_desc icl_power_wells[] = {
                },
        },
        {
+               .name = "DC off",
+               .domains = ICL_DISPLAY_DC_OFF_POWER_DOMAINS,
+               .ops = &gen9_dc_off_power_well_ops,
+               .id = DISP_PW_ID_NONE,
+       },
+       {
                .name = "power well 2",
                .domains = ICL_PW_2_POWER_DOMAINS,
                .ops = &hsw_power_well_ops,
@@ -2802,12 +2808,6 @@ static const struct i915_power_well_desc icl_power_wells[] = {
                },
        },
        {
-               .name = "DC off",
-               .domains = ICL_DISPLAY_DC_OFF_POWER_DOMAINS,
-               .ops = &gen9_dc_off_power_well_ops,
-               .id = DISP_PW_ID_NONE,
-       },
-       {
                .name = "power well 3",
                .domains = ICL_PW_3_POWER_DOMAINS,
                .ops = &hsw_power_well_ops,