Fix coding style (using checkpatch)
authorFrederic PAUT <frederic.paut@linux.intel.com>
Wed, 7 Mar 2012 14:01:34 +0000 (15:01 +0100)
committerFrederic PAUT <frederic.paut@linux.intel.com>
Wed, 7 Mar 2012 14:01:34 +0000 (15:01 +0100)
lib/neardal.c
lib/neardal.h
lib/neardal_adapter.c
lib/neardal_manager.c
lib/neardal_record.c
lib/neardal_record.h
lib/neardal_target.c
lib/neardal_target.h
lib/neardal_tools.c
ncl/ncl.c
ncl/ncl_cmd.c

index d17d1d9..374f908 100644 (file)
@@ -60,9 +60,8 @@ void neardal_prv_construct(errorCode_t *ec)
                                err, neardal_error_get_text(err));
 
                        /* No Neard daemon, destroying neardal object... */
-                       if (err == NEARDAL_ERROR_DBUS_CANNOT_CREATE_PROXY) {
+                       if (err == NEARDAL_ERROR_DBUS_CANNOT_CREATE_PROXY)
                                neardal_tools_prv_free_gerror(&neardalMgr);
-                       }
                }
        } else {
                NEARDAL_TRACE_ERR("Unable to connect to dbus: %s\n",
@@ -100,8 +99,8 @@ void neardal_destroy(void)
 errorCode_t neardal_set_cb_adapter_added(adapter_cb cb_adp_added,
                                         void *user_data)
 {
-       neardalMgr.cb_adp_added         = cb_adp_added;
-       neardalMgr.cb_adp_added_ud      = user_data;
+       neardalMgr.cb_adp_added         = cb_adp_added;
+       neardalMgr.cb_adp_added_ud      = user_data;
 
        return NEARDAL_SUCCESS;
 }
@@ -130,7 +129,7 @@ errorCode_t neardal_set_cb_adapter_property_changed(
                                        adapter_prop_cb cb_adp_property_changed,
                                        void *user_data)
 {
-       neardalMgr.cb_adp_prop_changed          = cb_adp_property_changed;
+       neardalMgr.cb_adp_prop_changed          = cb_adp_property_changed;
        neardalMgr.cb_adp_prop_changed_ud       = user_data;
 
        return NEARDAL_SUCCESS;
@@ -214,7 +213,7 @@ errorCode_t neardal_start_poll(char *adpName)
                neardal_prv_construct(&err);
        if (err != NEARDAL_SUCCESS)
                return err;
-       
+
        err = neardal_mgr_prv_get_adapter(adpName, &adpProp);
 
        err = NEARDAL_ERROR_NO_ADAPTER;
@@ -225,8 +224,8 @@ errorCode_t neardal_start_poll(char *adpName)
                goto exit;
 
        if (!adpProp->polling) {
-               org_neard_adp__call_start_poll_sync(adpProp->proxy, NULL, 
-                                               &neardalMgr.gerror);
+               org_neard_adp__call_start_poll_sync(adpProp->proxy, NULL,
+                                                   &neardalMgr.gerror);
 
                err = NEARDAL_SUCCESS;
                if (neardalMgr.gerror != NULL) {
@@ -305,7 +304,6 @@ errorCode_t neardal_publish(neardal_record *record)
        rcd.name                = (gchar *) record->name;
        rcd.action              = (gchar *) record->action;
        rcd.encoding            = (gchar *) record->encoding;
-       rcd.handOver            = (gboolean) record->handOver;
        rcd.language            = (gchar *) record->language;
        rcd.type                = (gchar *) record->type;
        rcd.representation      = (gchar *) record->representation;
@@ -462,7 +460,7 @@ exit:
  /******************************************************************************
  * neardal_get_record_properties: Get values of a specific target record
   *****************************************************************************/
-errorCode_t neardal_get_record_properties( const char *recordName,
+errorCode_t neardal_get_record_properties(const char *recordName,
                                          neardal_record *record)
 {
        errorCode_t     err             = NEARDAL_SUCCESS;
@@ -495,7 +493,6 @@ errorCode_t neardal_get_record_properties( const char *recordName,
 
        record->name            = (const char *) rcdProp->name;
        record->encoding        = (const char *) rcdProp->encoding;
-       record->handOver        = (short) rcdProp->handOver;
        record->language        = (const char *) rcdProp->language;
        record->action          = (const char *) rcdProp->action;
 
index 725a15a..c4f0c04 100644 (file)
@@ -95,24 +95,22 @@ typedef struct {
 typedef struct {
 /*! @brief DBus interface name (as identifier) */
        const char      *name;
-/*! @brief character encoding */
+/*! @brief The character encoding */
        const char      *encoding;
-/*! @brief connection established using other wireless communication
-technologies */
-       short           handOver;
-/*! @brief internation language used */
+/*! @brief The ISO/IANA language code (For example "en" or "jp") */
        const char      *language;
 /*! @brief 'Action' Save, Edit, Download... */
        const char      *action;
-/*! @brief tag type: 'Text', 'Uri', 'MIME Type' */
+/*! @brief The NDEF record type name ("SmartPoster", "Text", "URI",
+ * "HandoverRequest", "HandoverSelect", "HandoverCarrier" */
        const char      *type;
-/*! @brief Text datas */
+/*! @brief human readable representation of a text or title record. */
        const char      *representation;
-/*! @brief Uri datas */
+/*! @brief the complete URI, including the scheme and the resource */
        const char      *uri;
-//*! @brief Uri datas */
+/*! @brief URI object size */
        unsigned int    uriObjSize;
-/*! @brief MIME Type datas */
+/*! @brief The URI object MIME type */
        const char      *mime;
 } neardal_record;
 
index f3d6828..654fe42 100644 (file)
@@ -46,7 +46,7 @@ static void  neardal_adp_prv_cb_target_found(orgNeardTgt *proxy,
 
        NEARDAL_TRACEIN();
        (void) proxy; /* remove warning */
-       
+
        g_assert(arg_unnamed_arg0 != NULL);
        g_assert(adpProp != NULL);
 
@@ -122,15 +122,15 @@ static void neardal_adp_prv_cb_property_changed(orgNeardAdp *proxy,
                errCode = NEARDAL_ERROR_GENERAL_ERROR;
                goto exit;
        }
-       
+
        tmp = g_variant_get_variant(arg_unnamed_arg1);
        if (tmp == NULL) {
                errCode = NEARDAL_ERROR_GENERAL_ERROR;
                goto exit;
        }
-       
+
        if (!strcmp(arg_unnamed_arg0, "Polling")) {
-               adpProp->polling = g_variant_get_boolean  (tmp);                
+               adpProp->polling = g_variant_get_boolean(tmp);
                clientValue = GUINT_TO_POINTER(adpProp->polling);
                NEARDAL_TRACEF("neardalMgr.polling=%d\n", adpProp->polling);
        }
@@ -138,7 +138,7 @@ static void neardal_adp_prv_cb_property_changed(orgNeardAdp *proxy,
        if (!strcmp(arg_unnamed_arg0, "Targets")) {
                guint tmpLen;
 
-               tgtArray = g_variant_dup_objv (tmp, &tmpLen);
+               tgtArray = g_variant_dup_objv(tmp, &tmpLen);
                adpProp->tgtNb = tmpLen;
                if (tmpLen == 0) {
                        NEARDAL_TRACEF(
@@ -151,20 +151,19 @@ static void neardal_adp_prv_cb_property_changed(orgNeardAdp *proxy,
                                                               tgtProp->parent);
                        }
                        g_strfreev(tgtArray);
-                       
+
                        errCode = NEARDAL_SUCCESS;
                        goto exit;
                }
-               
+
                /* Extract the targets arrays List from the GValue */
                errCode = NEARDAL_ERROR_NO_ADAPTER;
                tmpLen = 0;
                while (tmpLen < adpProp->tgtNb) {
                        /* Getting last target (targets list not updated with
                         * targets lost */
-                       
-                       tgtName = g_strdup(tgtArray[tmpLen++]);
-                       
+                       tgtName = g_strdup(tgtArray[tmpLen++]);
+
                        /* TODO : for Neard Workaround, emulate 'TargetFound'
                         * signals */
                        errCode = neardal_mgr_prv_get_target(adpProp,
@@ -224,7 +223,7 @@ static errorCode_t neardal_adp_prv_read_properties(AdpProp *adpProp)
        NEARDAL_TRACE_LOG("Reading:\n%s\n", g_variant_print(tmp, TRUE));
        tmpOut = g_variant_lookup_value(tmp, "Targets", G_VARIANT_TYPE_ARRAY);
        if (tmpOut != NULL) {
-               tgtArray = g_variant_dup_objv (tmpOut, &len);
+               tgtArray = g_variant_dup_objv(tmpOut, &len);
                adpProp->tgtNb = len;
                if (len == 0) {
                        g_strfreev(tgtArray);
@@ -243,23 +242,23 @@ static errorCode_t neardal_adp_prv_read_properties(AdpProp *adpProp)
 
        tmpOut = g_variant_lookup_value(tmp, "Polling", G_VARIANT_TYPE_BOOLEAN);
        if (tmpOut != NULL)
-               adpProp->polling = g_variant_get_boolean  (tmpOut);
+               adpProp->polling = g_variant_get_boolean(tmpOut);
 
        tmpOut = g_variant_lookup_value(tmp, "Powered", G_VARIANT_TYPE_BOOLEAN);
        if (tmpOut != NULL)
-               adpProp->powered = g_variant_get_boolean  (tmpOut);
+               adpProp->powered = g_variant_get_boolean(tmpOut);
 
        tmpOut = g_variant_lookup_value(tmp, "Protocols",
                                        G_VARIANT_TYPE_ARRAY);
        if (tmpOut != NULL) {
-               adpProp->protocols = g_variant_dup_strv (tmpOut, &len);
+               adpProp->protocols = g_variant_dup_strv(tmpOut, &len);
                adpProp->lenProtocols = len;
                if (adpProp->lenProtocols == 0) {
                        g_strfreev(adpProp->protocols);
                        adpProp->protocols = NULL;
                }
        }
-       
+
 exit:
        return errCode;
 }
@@ -343,20 +342,20 @@ static errorCode_t neardal_adp_prv_init(AdpProp *adpProp)
        NEARDAL_TRACEF("Register Neard-Adapter Signal ");
        NEARDAL_TRACE("'PropertyChanged'\n");
        g_signal_connect(adpProp->proxy, NEARD_ADP_SIG_PROPCHANGED,
-                       G_CALLBACK (neardal_adp_prv_cb_property_changed),
+                       G_CALLBACK(neardal_adp_prv_cb_property_changed),
                          NULL);
 
        /* Register 'TargetFound', 'TargetLost' */
        NEARDAL_TRACEF("Register Neard-Adapter Signal ");
        NEARDAL_TRACE("'TargetFound'\n");
        g_signal_connect(adpProp->proxy, NEARD_ADP_SIG_TGT_FOUND,
-                       G_CALLBACK (neardal_adp_prv_cb_target_found),
+                       G_CALLBACK(neardal_adp_prv_cb_target_found),
                          adpProp);
 
        NEARDAL_TRACEF("Register Neard-Adapter Signal ");
        NEARDAL_TRACE("'TargetLost'\n");
        g_signal_connect(adpProp->proxy, NEARD_ADP_SIG_TGT_LOST,
-                       G_CALLBACK (neardal_adp_prv_cb_target_lost),
+                       G_CALLBACK(neardal_adp_prv_cb_target_lost),
                          adpProp);
 
        return errCode;
@@ -382,8 +381,6 @@ static void neardal_adp_prv_free(AdpProp **adpProp)
                (*adpProp)->proxy = NULL;
        }
        g_free((*adpProp)->name);
-// TODO remove if ((*adpProp)->tgtArray != NULL)
-//             g_strfreev((*adpProp)->tgtArray);
        if ((*adpProp)->protocols != NULL)
                g_strfreev((*adpProp)->protocols);
        g_free((*adpProp));
@@ -425,7 +422,7 @@ errorCode_t neardal_get_adapters(char ***array, int *len)
                }
        } else
                err = NEARDAL_ERROR_NO_ADAPTER;
-       
+
        if (len != NULL)
                *len = adpNb;
        *array  = adps;
@@ -453,7 +450,7 @@ errorCode_t neardal_adp_add(gchar *adapterName)
 
        adpProp->name = g_strdup(adapterName);
        adpProp->parent = &neardalMgr;
-       
+
        adpList = &neardalMgr.prop.adpList;
        *adpList = g_list_prepend(*adpList, (gpointer) adpProp);
        errCode = neardal_adp_prv_init(adpProp);
@@ -510,14 +507,14 @@ errorCode_t neardal_adp_remove(AdpProp *adpProp)
  *****************************************************************************/
 errorCode_t neardal_adp_publish(AdpProp *adpProp, RcdProp *rcd)
 {
-       GVariantBuilder *builder= NULL;
+       GVariantBuilder *builder = NULL;
        GVariant        *in;
        errorCode_t     err;
        GError          *gerror = NULL;
-       
+
        g_assert(adpProp != NULL);
 
-       builder = g_variant_builder_new (G_VARIANT_TYPE_ARRAY);
+       builder = g_variant_builder_new(G_VARIANT_TYPE_ARRAY);
        if (builder == NULL)
                return NEARDAL_ERROR_NO_MEMORY;
 
@@ -526,7 +523,7 @@ errorCode_t neardal_adp_publish(AdpProp *adpProp, RcdProp *rcd)
        if (err != NEARDAL_SUCCESS)
                goto exit;
 
-       in = g_variant_builder_end (builder);
+       in = g_variant_builder_end(builder);
        NEARDAL_TRACE_LOG("Sending:\n%s\n", g_variant_print(in, TRUE));
        org_neard_adp__call_publish_sync(adpProp->proxy, in, NULL, &gerror);
 
@@ -541,6 +538,6 @@ exit:
                g_variant_unref(in);
        if (builder != NULL)
                g_variant_builder_unref(builder);
-       
+
        return err;
 }
index f0c214d..f85cbde 100644 (file)
  * neardal_mgr_prv_cb_property_changed: Callback called when a NFC Manager
  * Property is changed
  *****************************************************************************/
-static void neardal_mgr_prv_cb_property_changed( orgNeardMgr *proxy,
-                                                const gchar *arg_unnamed_arg0,
-                                                GVariant *arg_unnamed_arg1,
-                                                void        *user_data)
+static void neardal_mgr_prv_cb_property_changed(orgNeardMgr *proxy,
+                                               const gchar *arg_unnamed_arg0,
+                                               GVariant *arg_unnamed_arg1,
+                                               void        *user_data)
 {
        NEARDAL_TRACEIN();
 
@@ -105,7 +105,7 @@ static void neardal_mgr_prv_cb_adapter_removed(orgNeardMgr *proxy,
                                         neardalMgr.cb_adp_removed_ud);
 
        neardal_adp_remove(((AdpProp *)node->data));
-       
+
        NEARDAL_TRACEF("NEARDAL LIB adapterList contains %d elements\n",
                      g_list_length(neardalMgr.prop.adpList));
 }
@@ -128,11 +128,11 @@ static errorCode_t neardal_mgr_prv_get_all_adapters(gchar ***adpArray,
                                             &neardalMgr.gerror)) {
                NEARDAL_TRACE_LOG("Reading:\n%s\n", g_variant_print(tmp, TRUE));
                NEARDAL_TRACEF("Parsing neard adapters...\n");
-               
+
                tmpOut = g_variant_lookup_value(tmp, "Adapters",
                                                G_VARIANT_TYPE_ARRAY);
                if (tmpOut != NULL) {
-                       *adpArray = g_variant_dup_objv (tmpOut, len);
+                       *adpArray = g_variant_dup_objv(tmpOut, len);
                        errCode = NEARDAL_SUCCESS;
                } else
                        errCode = NEARDAL_ERROR_NO_ADAPTER;
@@ -291,7 +291,7 @@ errorCode_t neardal_mgr_create(void)
                g_object_unref(neardalMgr.proxy);
                neardalMgr.proxy = NULL;
        }
-       
+
        neardalMgr.proxy = org_neard_mgr__proxy_new_sync(neardalMgr.conn,
                                        G_DBUS_OBJECT_MANAGER_CLIENT_FLAGS_NONE,
                                                        NEARD_DBUS_SERVICE,
@@ -323,21 +323,21 @@ errorCode_t neardal_mgr_create(void)
        NEARDAL_TRACEF("Register Neard-Manager Signal 'PropertyChanged'\n");
        g_signal_connect(neardalMgr.proxy,
                         NEARD_MGR_SIG_PROPCHANGED,
-                        G_CALLBACK (neardal_mgr_prv_cb_property_changed),
+                        G_CALLBACK(neardal_mgr_prv_cb_property_changed),
                         NULL);
 
        /* Register for manager signals 'AdapterAdded(ObjectPath)' */
        NEARDAL_TRACEF("Register Neard-Manager Signal 'AdapterAdded'\n");
        g_signal_connect(neardalMgr.proxy,
                         NEARD_MGR_SIG_ADP_ADDED,
-                        G_CALLBACK (neardal_mgr_prv_cb_adapter_added),
+                        G_CALLBACK(neardal_mgr_prv_cb_adapter_added),
                         NULL);
 
        /* Register for manager signals 'AdapterRemoved(ObjectPath)' */
        NEARDAL_TRACEF("Register Neard-Manager Signal 'AdapterRemoved'\n");
        g_signal_connect(neardalMgr.proxy,
                         NEARD_MGR_SIG_ADP_RM,
-                        G_CALLBACK (neardal_mgr_prv_cb_adapter_removed),
+                        G_CALLBACK(neardal_mgr_prv_cb_adapter_removed),
                         NULL);
 
        return errCode;
index 6ff4406..38481f2 100644 (file)
@@ -56,7 +56,7 @@ static errorCode_t neardal_rcd_prv_read_properties(RcdProp *rcd)
                return errCode;
        }
        NEARDAL_TRACE_LOG("Reading:\n%s\n", g_variant_print(tmp, TRUE));
-       
+
        tmpOut = g_variant_lookup_value(tmp, "Type", G_VARIANT_TYPE_STRING);
        if (tmpOut != NULL)
                rcd->type = g_variant_dup_string(tmpOut, NULL);
@@ -66,15 +66,11 @@ static errorCode_t neardal_rcd_prv_read_properties(RcdProp *rcd)
        if (tmpOut != NULL)
                rcd->representation = g_variant_dup_string(tmpOut,
                                                                NULL);
-               
+
        tmpOut = g_variant_lookup_value(tmp, "Encoding", G_VARIANT_TYPE_STRING);
        if (tmpOut != NULL)
                rcd->encoding = g_variant_dup_string(tmpOut, NULL);
 
-       tmpOut = g_variant_lookup_value(tmp, "HandOver", G_VARIANT_TYPE_BOOLEAN);
-       if (tmpOut != NULL)
-               rcd->handOver = g_variant_get_boolean  (tmpOut);
-
        tmpOut = g_variant_lookup_value(tmp, "Language", G_VARIANT_TYPE_STRING);
        if (tmpOut != NULL)
                rcd->language = g_variant_dup_string(tmpOut, NULL);
@@ -120,7 +116,7 @@ static errorCode_t neardal_rcd_prv_init(RcdProp *rcd)
                neardal_tools_prv_free_gerror(&neardalMgr);
                return NEARDAL_ERROR_DBUS_CANNOT_CREATE_PROXY;
        }
-       
+
        return neardal_rcd_prv_read_properties(rcd);
 }
 
@@ -176,7 +172,7 @@ errorCode_t neardal_rcd_prv_format(GVariantBuilder *builder, RcdProp *rcd)
                neardal_tools_add_dict_entry(builder, "URI", rcd->uri,
                                            (int) G_TYPE_STRING);
                neardal_tools_add_dict_entry(builder, "Size",
-                                           (void*) rcd->uriObjSize,
+                                           (void *) rcd->uriObjSize,
                                            (int) G_TYPE_UINT);
 
        }
@@ -187,7 +183,7 @@ errorCode_t neardal_rcd_prv_format(GVariantBuilder *builder, RcdProp *rcd)
        if (rcd->action != NULL)
                neardal_tools_add_dict_entry(builder, "Action", rcd->action,
                                            (int) G_TYPE_STRING);
-               
+
        return errCode;
 }
 
@@ -254,7 +250,7 @@ errorCode_t neardal_rcd_add(char *rcdName, void *parent)
        errorCode_t     errCode         = NEARDAL_ERROR_NO_MEMORY;
        RcdProp         *rcd    = NULL;
        TgtProp         *tgtProp = parent;
-       
+
        g_assert(rcdName != NULL);
        g_assert(parent != NULL);
 
@@ -268,7 +264,7 @@ errorCode_t neardal_rcd_add(char *rcdName, void *parent)
                goto exit;
 
        rcd->parent = tgtProp;
-       
+
        tgtProp->rcdList = g_list_prepend(tgtProp->rcdList, (gpointer) rcd);
        errCode = neardal_rcd_prv_init(rcd);
        if (errCode != NEARDAL_SUCCESS)
@@ -276,7 +272,7 @@ errorCode_t neardal_rcd_add(char *rcdName, void *parent)
 
        NEARDAL_TRACEF("NEARDAL LIB recordList contains %d elements\n",
                      g_list_length(tgtProp->rcdList));
-       
+
        errCode = NEARDAL_SUCCESS;
 
 exit:
@@ -296,7 +292,7 @@ exit:
 void neardal_rcd_remove(RcdProp *rcd)
 {
        TgtProp         *tgtProp;
-       
+
        NEARDAL_TRACEIN();
        g_assert(rcd != NULL);
 
index a1634ab..2d1f91b 100644 (file)
@@ -38,7 +38,6 @@ typedef struct {
        gboolean        notified; /* Already notified to client? */
 
        gchar           *encoding;
-       gboolean        handOver;
        gchar           *language;
        gchar           *action;
        gchar           *type;
index 0905046..8522651 100644 (file)
@@ -92,7 +92,7 @@ static errorCode_t neardal_tgt_prv_read_properties(TgtProp *tgtProp)
        NEARDAL_TRACE_LOG("Reading:\n%s\n", g_variant_print(tmp, TRUE));
        tmpOut = g_variant_lookup_value(tmp, "Records", G_VARIANT_TYPE_ARRAY);
        if (tmpOut != NULL) {
-               rcdArray = g_variant_dup_objv (tmpOut, &len);
+               rcdArray = g_variant_dup_objv(tmpOut, &len);
                tgtProp->rcdLen = len;
                if (len == 0) {
                        g_strfreev(rcdArray);
@@ -111,7 +111,7 @@ static errorCode_t neardal_tgt_prv_read_properties(TgtProp *tgtProp)
 
        tmpOut = g_variant_lookup_value(tmp, "TagType", G_VARIANT_TYPE_ARRAY);
        if (tmpOut != NULL) {
-               tgtProp->tagType = g_variant_dup_strv (tmpOut, &len);
+               tgtProp->tagType = g_variant_dup_strv(tmpOut, &len);
                tgtProp->tagTypeLen = len;
                if (len == 0) {
                        g_strfreev(tgtProp->tagType);
@@ -123,9 +123,10 @@ static errorCode_t neardal_tgt_prv_read_properties(TgtProp *tgtProp)
        if (tmpOut != NULL)
                tgtProp->type = g_variant_dup_string(tmpOut, NULL);
 
-       tmpOut = g_variant_lookup_value(tmp, "ReadOnly", G_VARIANT_TYPE_BOOLEAN);
+       tmpOut = g_variant_lookup_value(tmp, "ReadOnly",
+                                       G_VARIANT_TYPE_BOOLEAN);
        if (tmpOut != NULL)
-               tgtProp->readOnly = g_variant_get_boolean  (tmpOut);
+               tgtProp->readOnly = g_variant_get_boolean(tmpOut);
 
 exit:
        return errCode;
@@ -174,7 +175,7 @@ static errorCode_t neardal_tgt_prv_init(TgtProp *tgtProp)
 
        NEARDAL_TRACEF("Register Neard-Target Signal 'PropertyChanged'\n");
        g_signal_connect(tgtProp->proxy, NEARD_TGT_SIG_PROPCHANGED,
-                       G_CALLBACK (neardal_tgt_prv_cb_property_changed),
+                       G_CALLBACK(neardal_tgt_prv_cb_property_changed),
                          tgtProp);
 
        return errCode;
@@ -208,10 +209,9 @@ void neardal_tgt_notify_target_found(TgtProp *tgtProp)
 {
        RcdProp *rcdProp;
        gsize   len;
-       
+
        g_assert(tgtProp != NULL);
-       
-               
+
        if (tgtProp->notified == FALSE && neardalMgr.cb_tgt_found != NULL) {
                (neardalMgr.cb_tgt_found)(tgtProp->name,
                                           neardalMgr.cb_tgt_found_ud);
@@ -224,7 +224,7 @@ void neardal_tgt_notify_target_found(TgtProp *tgtProp)
                        rcdProp = g_list_nth_data(tgtProp->rcdList, len++);
                        if (rcdProp->notified == FALSE) {
                                (neardalMgr.cb_rcd_found)(rcdProp->name,
-                                                       neardalMgr.cb_rcd_found_ud);
+                                               neardalMgr.cb_rcd_found_ud);
                                rcdProp->notified = TRUE;
                        }
                }
@@ -301,7 +301,7 @@ errorCode_t neardal_tgt_add(gchar *tgtName, void * parent)
 
        NEARDAL_TRACEF("NEARDAL LIB targetList contains %d elements\n",
                      g_list_length(adpProp->tgtList));
-       
+
        return errCode;
 
 error:
@@ -335,6 +335,6 @@ void neardal_tgt_remove(TgtProp *tgtProp)
        adpProp = tgtProp->parent;
        adpProp->tgtList = g_list_remove(adpProp->tgtList,
                                         (gconstpointer) tgtProp);
-       
+
        neardal_tgt_prv_free(&tgtProp);
 }
index acef3a6..1bab15a 100644 (file)
@@ -23,7 +23,6 @@
 
 #include "neard_target_proxy.h"
 #include "neardal_record.h"
-// #include <glib-2.0/glib/gtypes.h>
 
 #ifdef __cplusplus
 extern "C" {
@@ -38,12 +37,12 @@ typedef struct {
        gchar           *name;    /* DBus interface name (as identifier) */
        void            *parent;  /* parent (adapter ) */
        gboolean        notified; /* Already notified to client? */
-       
+
        gchar           *type;
-       
+
        gsize           rcdLen;
        GList           *rcdList;       /* target's records paths */
-       
+
        gchar           **tagType;      /* array of tag types */
        gsize           tagTypeLen;
        gboolean        readOnly;       /* Read-Only flag */
index dbb9e60..d0bf565 100644 (file)
@@ -95,7 +95,7 @@ errorCode_t neardal_tools_add_dict_entry(GVariantBuilder *builder, gchar *key,
        GVariant *tmp;
        g_assert(builder != NULL);
 
-       switch(gVariantType) {
+       switch (gVariantType) {
        case G_TYPE_STRING:
                tmp = g_variant_new_string(value);
                break;
@@ -104,7 +104,7 @@ errorCode_t neardal_tools_add_dict_entry(GVariantBuilder *builder, gchar *key,
                break;
        }
        g_variant_builder_add(builder, "{sv}", key, tmp);
-       
+
        return NEARDAL_SUCCESS;
 }
 
index a92ed75..201a869 100644 (file)
--- a/ncl/ncl.c
+++ b/ncl/ncl.c
@@ -70,9 +70,9 @@ static NCLError ncl_prv_split_cmdLine(gchar  *cmdLine, int *iArgc,
        NCLError        err     = NCLERR_NOERROR;
        char            **argv  = NULL;
        int             *argc;
-       char            *argEnd;
+       char            *argEnd;
        char            *argStart;
-       bool            inQuotes;
+       bool            inQuotes;
        gssize          argSize;
 
        /* Test input parameters */
@@ -87,9 +87,8 @@ static NCLError ncl_prv_split_cmdLine(gchar  *cmdLine, int *iArgc,
 
        argStart = argEnd = cmdLine;
        while ((*argc) < NB_MAX_PARAMETERS && *argEnd != '\0') {
-               while(*argEnd != ' ' && *argEnd != '"' && *argEnd != '\0') {
+               while (*argEnd != ' ' && *argEnd != '"' && *argEnd != '\0')
                        argEnd++;
-               }
                if (*argEnd == '"') {
                        if (inQuotes == false)
                                argStart = argEnd + 1;
@@ -106,7 +105,7 @@ static NCLError ncl_prv_split_cmdLine(gchar  *cmdLine, int *iArgc,
                } else
                        argEnd++;
        }
+
        return err;
 }
 
index b3ee194..dfc6cd9 100644 (file)
@@ -128,7 +128,6 @@ static NCLCmdInterpretor itFunc[];
 NCLError ncl_cmd_list(int argc, char *argv[])
 {
        int index;
-       char funcName[50];
        int  nbCmd = ncl_cmd_get_nbCmd();
 
        (void) argc; /* remove warning */
@@ -136,16 +135,9 @@ NCLError ncl_cmd_list(int argc, char *argv[])
 
        ncl_cmd_print(stdout, "\nCommand line list\n");
        for (index = 0; index < nbCmd; index++) {
-       if (0) { /* TODO: Remove */
-               snprintf(funcName, sizeof(funcName), "%40s",
-                        itFunc[index].cmdName);
-               ncl_cmd_print(stdout, "%s :\t%s\n", funcName,
-                             itFunc[index].helpStr);
-       } else {
                ncl_cmd_print(stdout, "%s :\n\t%s\n\n", itFunc[index].cmdName,
                              itFunc[index].helpStr);
        }
-       }
 
        return 0;
 }
@@ -244,11 +236,8 @@ static void ncl_cmd_prv_dump_record(neardal_record record)
        NCL_CMD_PRINT("Record\n");
        NCL_CMD_PRINT(".. Name:\t\t%s\n"        , record.name);
        NCL_CMD_PRINT(".. Encoding:\t\t%s\n"    , record.encoding);
-       NCL_CMD_PRINT(".. HandOver:\t\t%s\n"    ,
-                     record.handOver ? "TRUE" : "FALSE");
        NCL_CMD_PRINT(".. Language:\t\t%s\n"    , record.language);
        NCL_CMD_PRINT(".. Action:\t\t%s\n"      , record.action);
-
        NCL_CMD_PRINT(".. Type:\t\t%s\n"        , record.type);
        NCL_CMD_PRINT(".. Representation:\t%s\n", record.representation);
        NCL_CMD_PRINT(".. URI:\t\t\t%s\n"       , record.uri);
@@ -265,7 +254,7 @@ static void ncl_cmd_cb_adapter_added(const char *adpName, void *user_data)
        neardal_adapter adapter;
 
        (void) user_data; /* Remove warning */
-       
+
        NCL_CMD_PRINTF("NFC Adapter added '%s'\n", adpName);
        ec = neardal_get_adapter_properties(adpName, &adapter);
        if (ec == NEARDAL_SUCCESS)
@@ -281,7 +270,7 @@ static void ncl_cmd_cb_adapter_added(const char *adpName, void *user_data)
 static void ncl_cmd_cb_adapter_removed(const char *adpName, void * user_data)
 {
        (void) user_data; /* remove warning */
-       
+
        NCL_CMD_PRINTF("NFC Adapter removed '%s'\n", adpName);
 }
 
@@ -291,7 +280,7 @@ static void ncl_cmd_cb_adapter_prop_changed(char *adpName, char *propName,
        int             polling;
 
        (void) user_data; /* remove warning */
-       
+
        if (!strcmp(propName, "Polling")) {
                polling = (int)value;
                NCL_CMD_PRINTF("Polling=%d\n", polling);
@@ -333,7 +322,7 @@ static void ncl_cmd_cb_record_found(const char *rcdName, void *user_data)
        neardal_record  record;
 
        (void) user_data; /* remove warning */
-       
+
        NCL_CMD_PRINTF("Target Record found (%s)\n", rcdName);
        ec = neardal_get_record_properties(rcdName, &record);
        if (ec == NEARDAL_SUCCESS) {
@@ -380,7 +369,7 @@ static NCLError ncl_cmd_neardal_get_adapters(int argc, char *argv[])
 
        (void) argc; /* Remove warning */
        (void) argv; /* Remove warning */
-       
+
        /* Install Neardal Callback*/
        if (sNclCmdCtx.cb_initialized == false)
                ncl_cmd_install_callback();
@@ -667,7 +656,7 @@ static GOptionEntry options[] = {
                ncl_cmd_print(stdout, "e.g. < publish --type=SmartPoster \
 --uri=http://www.nfc-forum.com > --adp /org/neard/nfc0 >\n");
        }
-       
+
        if (nclErr != NCLERR_NOERROR)
                goto exit;
 
@@ -882,7 +871,7 @@ static NCLError ncl_cmd_quit(int argc, char *argv[])
 
        /* Release NEARDAL object */
        neardal_destroy();
-       
+
        /* Quit Main Loop */
        if (nclCtxP)
                g_main_loop_quit(nclCtxP->main_loop);