ASoC: SOF: imx8: Fix an is IS_ERR() vs NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 26 Aug 2019 13:18:55 +0000 (16:18 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 27 Aug 2019 18:22:17 +0000 (19:22 +0100)
The device_link_add() function only returns NULL on error, it doesn't
return error pointers.

Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://lore.kernel.org/r/20190826131855.GA6840@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/imx/imx8.c

index c9d849c..2a22b18 100644 (file)
@@ -227,8 +227,8 @@ static int imx8_probe(struct snd_sof_dev *sdev)
                                                DL_FLAG_STATELESS |
                                                DL_FLAG_PM_RUNTIME |
                                                DL_FLAG_RPM_ACTIVE);
-               if (IS_ERR(priv->link[i])) {
-                       ret = PTR_ERR(priv->link[i]);
+               if (!priv->link[i]) {
+                       ret = -ENOMEM;
                        dev_pm_domain_detach(priv->pd_dev[i], false);
                        goto exit_unroll_pm;
                }